Restore correctness check for win condition

Author: backspace

registrations/lib/registrations/waydowntown.ex

@@ -604,9 +604,10 @@ defmodule Registrations.Waydowntown do
 
       concept when concept in ["bluetooth_collector", "code_collector", "string_collector", "food_court_frenzy"] ->
         run_answer_count = length(run.specification.answers)
-        submissions_by_user = Enum.group_by(run.submissions, & &1.creator_id)
+        correct_submissions = Enum.filter(run.submissions, & &1.correct)
+        correct_submissions_by_user = Enum.group_by(correct_submissions, & &1.creator_id)
 
-        Enum.any?(Map.values(submissions_by_user), &(length(&1) == run_answer_count))
+        Enum.any?(Map.values(correct_submissions_by_user), &(length(&1) == run_answer_count))
 
       # FIXME these all need fixing, and order is missing
       "orientation_memory" ->

registrations/test/registrations_web/controllers/submission_controller_test.exs

@@ -795,7 +795,7 @@ defmodule RegistrationsWeb.SubmissionControllerTest do
       assert included_run["attributes"]["total_answers"] == 3
     end
 
-    test "win check is user-scoped", %{conn: conn, run: run, user: user} do
+    test "win check is user- and correctness-scoped", %{conn: conn, run: run, user: user} do
       other_user = insert(:user)
 
       Repo.insert!(%Submission{
@@ -812,6 +812,20 @@ defmodule RegistrationsWeb.SubmissionControllerTest do
         creator: other_user
       })
 
+      Repo.insert!(%Submission{
+        submission: "first string",
+        run_id: run.id,
+        correct: true,
+        creator: user
+      })
+
+      Repo.insert!(%Submission{
+        submission: "non string",
+        run_id: run.id,
+        correct: false,
+        creator: user
+      })
+
       conn =
         conn
         |> setup_conn(user)