Skip to content

neil add on a dep with :git/sha ends up with both :git/sha and :mvn/version #249

@teodorlu

Description

@teodorlu

System information

$ bb --version 
babashka v1.12.195
$ neil --version
neil 0.3.68
image

Problem

neil add on a dep with :git/sha ends up with both :git/sha and :mvn/version. I don't think that makes sense.

Repro

$ cat deps.edn 
{:paths ["src" "notebooks"]
 :deps {io.github.nextjournal/clerk {:git/sha "285c20ee6bff22a14c7ea2be274d9ac0a37b7668"}}
 :aliases
 {:nextjournal/garden {:exec-fn nextjournal.clerk/serve!
                       :exec-args {:index "notebooks/hello.clj"}}}}
$ neil dep add io.github.nextjournal/clerk
$ cat deps.edn 
{:paths ["src" "notebooks"]
 :deps {io.github.nextjournal/clerk {:git/sha "285c20ee6bff22a14c7ea2be274d9ac0a37b7668"
                                     :mvn/version "0.17.1102"}}
 :aliases
 {:nextjournal/garden {:exec-fn nextjournal.clerk/serve!
                       :exec-args {:index "notebooks/hello.clj"}}}}

Expected behavior

:git/sha is deleted, only the version Neil found remains.

$ cat deps.edn 
{:paths ["src" "notebooks"]
 :deps {io.github.nextjournal/clerk {:mvn/version "0.17.1102"}}
 :aliases
 {:nextjournal/garden {:exec-fn nextjournal.clerk/serve!
                       :exec-args {:index "notebooks/hello.clj"}}}}

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions