Skip to content

Commit a84603c

Browse files
authored
[Functions] Fix logging mismatches in tests (Azure#50626)
* [Functions] Fix logging mismatches in tests The focus of these changes is to attempt to fix the test failures that seem to occur only in nightly test pipelines. * Suppressing analyzer rule for tables, due to external code * Tweaking dependencies to unwind logging mismatch * Updating AppInsights tests * Ignoring AppInsights tests for now * Removing AppInsights tests from the Event Hubs package. The functionality tested was two external packages and not the logic in the extension itself. It was also something that no other package tested. * Fixing warnings * Update sdk/eventhub/Microsoft.Azure.WebJobs.Extensions.EventHubs/tests/Microsoft.Azure.WebJobs.Extensions.EventHubs.Tests.csproj
1 parent a14e794 commit a84603c

File tree

12 files changed

+35
-451
lines changed

12 files changed

+35
-451
lines changed

eng/Packages.Data.props

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -242,17 +242,17 @@
242242
<PackageReference Update="Microsoft.Azure.SignalR.Management" Version="1.29.0" />
243243
<PackageReference Update="Microsoft.Azure.SignalR.Protocols" Version="1.29.0" />
244244
<PackageReference Update="Microsoft.Azure.SignalR.Serverless.Protocols" Version="1.10.0" />
245-
<PackageReference Update="Microsoft.Azure.WebJobs" Version="3.0.37" />
246-
<PackageReference Update="Microsoft.Azure.WebJobs.Sources" Version="3.0.37" PrivateAssets="All"/>
247-
<PackageReference Update="Microsoft.Azure.WebJobs.Extensions.Rpc" Version="3.0.37" />
248-
<PackageReference Update="Microsoft.Azure.WebJobs.Host.Storage" Version="5.0.0" />
245+
<PackageReference Update="Microsoft.Azure.WebJobs" Version="3.0.41" />
246+
<PackageReference Update="Microsoft.Azure.WebJobs.Sources" Version="3.0.41" PrivateAssets="All"/>
247+
<PackageReference Update="Microsoft.Azure.WebJobs.Extensions.Rpc" Version="3.0.41" />
248+
<PackageReference Update="Microsoft.Azure.WebJobs.Host.Storage" Version="5.0.1" />
249249
<PackageReference Update="Microsoft.Spatial" Version="7.5.3" />
250250
<PackageReference Update="Newtonsoft.Json" Version="13.0.3" />
251251
</ItemGroup>
252252

253253
<!-- Packages intended for Extensions libraries only -->
254254
<ItemGroup Condition="'$(IsExtensionClientLibrary)' == 'true'">
255-
<PackageReference Update="Microsoft.AspNetCore.DataProtection" Version="8.0.16" />
255+
<PackageReference Update="Microsoft.AspNetCore.DataProtection" Version="8.0.19" />
256256
<PackageReference Update="Microsoft.AspNetCore.Http" Version="2.3.0" />
257257
<PackageReference Update="Microsoft.AspNetCore.Http.Connections" Version="1.2.0" />
258258
<PackageReference Update="Microsoft.Azure.Functions.Worker.Extensions.Abstractions" Version="1.3.0" />
@@ -350,7 +350,8 @@
350350
<PackageReference Update="CommandLineParser" Version="2.8.0" />
351351
<PackageReference Update="FluentAssertions" Version="5.10.3" />
352352
<PackageReference Update="FsCheck.Xunit" Version="2.14.0" />
353-
<PackageReference Update="Microsoft.ApplicationInsights" Version="2.20.0" />
353+
<PackageReference Update="Microsoft.ApplicationInsights" Version="2.23.0" />
354+
<PackageReference Update="Microsoft.ApplicationInsights.WorkerService" Version="2.23.0" />
354355
<PackageReference Update="Microsoft.Azure.ApplicationInsights.Query" Version="1.0.0" />
355356
<PackageReference Update="Microsoft.AspNetCore" Version="2.2.0" />
356357
<PackageReference Update="Microsoft.AspNetCore.Mvc.Testing" Version="2.2.0" />
@@ -386,7 +387,7 @@
386387
<PackageReference Update="Microsoft.Azure.Storage.Queue" Version="11.1.7" />
387388
<PackageReference Update="Microsoft.Azure.Test.HttpRecorder" Version="[1.13.3, 2.0.0)" />
388389
<PackageReference Update="Microsoft.Azure.WebJobs.Extensions" Version="5.0.0" />
389-
<PackageReference Update="Microsoft.Azure.WebJobs.Extensions.Http" Version="3.0.2" />
390+
<PackageReference Update="Microsoft.Azure.WebJobs.Extensions.Http" Version="3.2.0" />
390391
<PackageReference Update="Microsoft.CodeAnalysis.CSharp.Workspaces" Version="4.8.0" />
391392
<PackageReference Update="Microsoft.CSharp" Version="4.7.0" />
392393
<PackageReference Update="Microsoft.Data.SqlClient" Version="5.2.2" />
@@ -397,6 +398,7 @@
397398
<PackageReference Update="Microsoft.Extensions.Configuration" Version="8.0.0" />
398399
<PackageReference Update="Microsoft.Extensions.Hosting" Version="8.0.1" />
399400
<PackageReference Update="Microsoft.Extensions.Logging" Version="8.0.1" />
401+
<PackageReference Update="Microsoft.Extensions.Logging.ApplicationInsights" Version="2.23.0" />
400402
<PackageReference Update="Microsoft.Extensions.Logging.Configuration" Version="8.0.1" />
401403
<PackageReference Update="Microsoft.Extensions.Logging.Console" Version="8.0.1"/>
402404
<PackageReference Update="Microsoft.Extensions.Primitives" Version="8.0.0"/>

sdk/eventhub/Microsoft.Azure.WebJobs.Extensions.EventHubs/src/Triggers/EventHubTriggerBindingStrategy.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -161,7 +161,7 @@ private static void SafeAddValue(Action addValue)
161161
}
162162
catch
163163
{
164-
// some message propery getters can throw, based on the
164+
// some message property getters can throw, based on the
165165
// state of the message
166166
}
167167
}

0 commit comments

Comments
 (0)