Skip to content

Commit c7907ad

Browse files
Apply suggestions from code review
Co-authored-by: José Corella <[email protected]>
1 parent 2b6d411 commit c7907ad

File tree

2 files changed

+10
-10
lines changed

2 files changed

+10
-10
lines changed

changes/2025-01-17_key-store-admin/background.md

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,7 @@ are also different between usage and administration activities.
2525

2626
As such, it makes sense to create a
2727
new Branch Key Store Administration Client,
28-
that cannot facilitate usage,
29-
only administrative operations.
28+
that only facilitates administrative operations.
3029

3130
## Alternatives to a new Client/Local Service?
3231

@@ -42,7 +41,7 @@ and is therefore not recommended.
4241
Creating a new Key Store Admin client
4342
also passively encourages customers to
4443
consider the different permissions needed
45-
to administrate rather than use a Key Store.
44+
to administer rather than use a Key Store.
4645

4746
### Static Methods on the MPL
4847

@@ -89,7 +88,7 @@ on Storage Reference.
8988

9089
`Kms Symmetric Key Arn` is a Union.
9190

92-
The members of ``KmsSymmetricKeyArn` are a KMS ARN which identifies the KMS Key
91+
The members of `KmsSymmetricKeyArn` are a KMS ARN which identifies the KMS Symmetric Key
9392
that will be used for the operation.
9493
This ARN MUST NOT be an Alias.
9594
This ARN MUST be a valid

framework/branch-key-store-admin.md

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ See [Key Store Overview](../branch-key-store.md#definitions).
3939

4040
`Kms Symmetric Key Arn` is a Union.
4141

42-
The members of ``KmsSymmetricKeyArn` are a KMS ARN which identifies the KMS Key
42+
The members of `KmsSymmetricKeyArn` are a KMS ARN which identifies the KMS Key
4343
that will be used for the operation.
4444
This ARN MUST NOT be an Alias.
4545
This ARN MUST be a valid
@@ -78,9 +78,10 @@ during [Wrapped Branch Key Creation](../branch-key-store.md#wrapped-branch-key-c
7878

7979
`AwsKmsReEncrypt` is a structure that holds a [`AwsKms`](../branch-key-store.md#awskms),
8080
which MAY contain the KMS Client
81-
or Grant Tokens the Key Store,
81+
or Grant Tokens,
8282
if they are set,
83-
will use when calling KMS.
83+
the Key Store will use
84+
when calling KMS.
8485

8586
`AwsKmsReEncrypt` is the default option if
8687
`Key Management Strategy` is marked as optional
@@ -107,7 +108,7 @@ in this document are to be interpreted as described in [RFC 2119](https://tools.
107108

108109
## Initialization
109110

110-
The Key Store Admin requires the following arguments:
111+
On initialization the caller MUST provide:
111112

112113
- [Storage](../branch-key-store.md#storage)
113114
- [Logical Key Store Name](../branch-key-store.md##logical-keystore-name)
@@ -146,7 +147,7 @@ with the following caveats:
146147

147148
#### KMS Configuration
148149

149-
Where ever the Key Store Client's CreateKey method refers to the Key Store's KMS Configuration,
150+
Wherever the Key Store Client's CreateKey method refers to the Key Store's KMS Configuration,
150151
use the equivalent [`KmsSymmetricKeyArn`](#kmssymmetrickeyarn) expression.
151152

152153
#### [Branch Key and Beacon Key Creation](./branch-key-store.md#branch-key-and-beacon-key-creation)
@@ -172,7 +173,7 @@ with the following caveats:
172173

173174
#### KMS Configuration
174175

175-
Where ever the Key Store Client's CreateKey method refers to the Key Store Client's KMS Configuration,
176+
Where ever the Key Store Client's VersionKey method refers to the Key Store Client's KMS Configuration,
176177
use the equivalent [`KmsSymmetricKeyArn`](#kmssymmetrickeyarn) expression.
177178

178179
#### [Wrapped Branch Key Creation](./branch-key-store.md#wrapped-branch-key-creation)

0 commit comments

Comments
 (0)