Skip to content

Commit 5ae98ab

Browse files
author
Feiyang Liu
committed
fix: use direct artifact filenames without commit-sha in SageMaker workflow
1 parent a44432a commit 5ae98ab

1 file changed

Lines changed: 6 additions & 8 deletions

File tree

.github/workflows/smoke-tests-sagemaker.yaml

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ jobs:
1616
GH_REF_NAME: ${{ github.ref_name }}
1717
SAGEMAKER_ARTIFACT_PREFIX: "code-editor-sagemaker-server"
1818
GH_TOKEN: ${{ github.token }}
19-
AWS_REGION: us-east-2
19+
AWS_REGION: us-east-1
2020
AWS_ACCOUNT_ID: ${{ secrets.AWS_ACCOUNT_ID }}
2121
ECR_REPOSITORY: ${{ secrets.ECR_REPOSITORY }}
2222
PROJECT_NAME: ${{ secrets.PROJECT_NAME }}
@@ -48,7 +48,7 @@ jobs:
4848
ls -la
4949
5050
FILES=(
51-
"$COMMIT_SHA-$SAGEMAKER_ARTIFACT_PREFIX-build/$SAGEMAKER_ARTIFACT_PREFIX-build.tar.gz"
51+
"$SAGEMAKER_ARTIFACT_PREFIX-build.tar.gz"
5252
)
5353
5454
# Check build artifact exists
@@ -67,7 +67,7 @@ jobs:
6767

6868
- name: Extract artifacts
6969
run: |
70-
tar -xzf "$COMMIT_SHA-$SAGEMAKER_ARTIFACT_PREFIX-build/$SAGEMAKER_ARTIFACT_PREFIX-build.tar.gz"
70+
tar -xzf "$SAGEMAKER_ARTIFACT_PREFIX-build.tar.gz"
7171
7272
- name: Build and push Docker image
7373
run: |
@@ -100,7 +100,6 @@ jobs:
100100
docker rmi $ECR_REPOSITORY:$IMAGE_TAG $AWS_ACCOUNT_ID.dkr.ecr.$AWS_REGION.amazonaws.com/$ECR_REPOSITORY:$IMAGE_TAG
101101
echo "Local Docker images cleaned up"
102102
rm -rf vscode-reh-web-linux-x64
103-
rm -rf $COMMIT_SHA-$SAGEMAKER_ARTIFACT_PREFIX-build
104103
echo "Local build artifacts cleaned up"
105104
106105
- name: Configure SageMaker role AWS credentials
@@ -290,7 +289,7 @@ jobs:
290289
ls -la
291290
292291
FILES=(
293-
"$COMMIT_SHA-$SAGEMAKER_ARTIFACT_PREFIX-src/$SAGEMAKER_ARTIFACT_PREFIX-src.tar.gz"
292+
"$SAGEMAKER_ARTIFACT_PREFIX-src.tar.gz"
294293
)
295294
296295
# Check build artifact exists
@@ -301,8 +300,7 @@ jobs:
301300
fi
302301
done
303302
304-
tar -xzf "$COMMIT_SHA-$SAGEMAKER_ARTIFACT_PREFIX-src/$SAGEMAKER_ARTIFACT_PREFIX-src.tar.gz"
305-
rm -rf $COMMIT_SHA-$SAGEMAKER_ARTIFACT_PREFIX-src
303+
tar -xzf "$SAGEMAKER_ARTIFACT_PREFIX-src.tar.gz"
306304
307305
308306
- name: E2E testing
@@ -340,7 +338,7 @@ jobs:
340338
exit 1
341339
fi
342340
343-
DATAZONE_URL="https://${DATAZONE_DOMAIN_ID}.sagemaker.us-west-2.on.aws/projects/${PROJECT_ID}/compute?type=spaces"
341+
DATAZONE_URL="https://${DATAZONE_DOMAIN_ID}.sagemaker.us-east-1.on.aws/projects/${PROJECT_ID}/compute?type=spaces"
344342
345343
# Apply E2E testing patches
346344

0 commit comments

Comments
 (0)