Skip to content

Conversation

@L-Applin
Copy link
Contributor

@L-Applin L-Applin commented Nov 26, 2025

Feature branch merge for the parallel multipart download feature

@L-Applin L-Applin added the api-surface-area-approved-by-team Indicate API surface area introduced by this PR has been approved by team label Nov 26, 2025
@L-Applin L-Applin changed the title Feature/master/large object dl Parallel multipart download Nov 26, 2025
@L-Applin L-Applin marked this pull request as ready for review November 27, 2025 18:28
@L-Applin L-Applin requested a review from a team as a code owner November 27, 2025 18:28
Make Sonar happy
- remove unused fields
- remove unused test imports and comments
- uncomment test
- add missing asserts
@L-Applin L-Applin requested a review from joviegas November 28, 2025 22:05
@joviegas
Copy link
Contributor

joviegas commented Nov 28, 2025

@L-Applin I donot see #6425 approval , can you please confirm if this was approved offline and by whom.
If 6425 was already approved then I can give a quick approval for this one else it might take some time for me to do a complete review

Copy link
Contributor

@joviegas joviegas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved as discussed offline #6425 was approved offline

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 1, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
76.7% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@L-Applin L-Applin added this pull request to the merge queue Dec 2, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 2, 2025
@L-Applin L-Applin added this pull request to the merge queue Dec 2, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 2, 2025
@L-Applin L-Applin added this pull request to the merge queue Dec 2, 2025
Merged via the queue into master with commit dd4efa7 Dec 2, 2025
107 of 119 checks passed
@github-actions
Copy link

github-actions bot commented Dec 2, 2025

This pull request has been closed and the conversation has been locked. Comments on closed PRs are hard for our team to see. If you need more assistance, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api-surface-area-approved-by-team Indicate API surface area introduced by this PR has been approved by team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants