fix(mixins-preview): strongly-typed ConstructSelector interface #36266
+163
−49
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for this change
The
ConstructSelectorAPI in mixins-preview was too restrictive, only accepting specific selector types rather than allowing custom implementations. Additionally,byId()used regex patterns which are less intuitive than glob patterns for path matching.Description of changes
This PR introduces a strongly-typed
IConstructSelectorinterface and improves selector functionality:Breaking Changes:
Mixins.of()now acceptsIConstructSelectorinstead of the concreteConstructSelectorclass, enabling custom selector implementationsConstructSelector.byId()now uses glob patterns instead of regular expressions for more intuitive matchingConstructSelector.resourcesOfType()now requires string CloudFormation resource type names instead of accepting class referencesNew Features:
IConstructSelectorinterface for custom selector implementationsConstructSelector.byPath()to match on construct paths using glob patternsminimatchdependency for glob pattern matchingExamples:
Describe any new or updated permissions being added
No new or updated IAM permissions are needed.
Description of how you validated changes
byPath()selectorChecklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license