Fix of using existing vpc #66
Closed
+78
−52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schuettc
added a commit
that referenced
this pull request
Dec 1, 2025
Fix of using existing vpc Add dedicated stack s3bucket. Skip networking stack if user choose to use existing VPC. In case of using existing VPC, we pass subnets and vpc to monitoring stack from user input. Fixes #55 # Conflicts: # source/claude_code_with_bedrock/cli/commands/deploy.py
schuettc
added a commit
that referenced
this pull request
Dec 1, 2025
Corrects variable name typo in deploy.py where 'vpc_congig' was used instead of 'vpc_config' in two locations (lines 164-165 and 586-590). This is a follow-up fix to PR #66.
schuettc
added a commit
that referenced
this pull request
Dec 1, 2025
Corrects variable name typo in deploy.py where 'vpc_congig' was used instead of 'vpc_config' in two locations (lines 164-165 and 586-590). This is a follow-up fix to PR #66.
Contributor
|
Thanks for the help! Merged in. Appreciate it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #55
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.