Skip to content

Commit 7e40573

Browse files
authored
Release/4.1.1 (#1170)
* release 4.1.1 * fix dependency bug * fix versioning
1 parent 4deb6eb commit 7e40573

File tree

4 files changed

+11
-10
lines changed

4 files changed

+11
-10
lines changed

cfn-templates/cid-cfn.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
AWSTemplateFormatVersion: '2010-09-09'
2-
Description: Deployment of Cloud Intelligence Dashboards v4.1.0
2+
Description: Deployment of Cloud Intelligence Dashboards v4.1.1
33
Metadata:
44
AWS::CloudFormation::Interface:
55
ParameterGroups:
@@ -2052,7 +2052,7 @@ Resources:
20522052
SourceBucket: !Ref ReferenceAssetsBucket
20532053
DestinationBucket: !Ref LocalAssetsBucket
20542054
Keys:
2055-
- 'cid-resource-lambda-layer/cid-4.1.0.zip' #replace version here if needed
2055+
- 'cid-resource-lambda-layer/cid-4.1.1.zip' #replace version here if needed
20562056

20572057
CidResourceLambdaLayer:
20582058
Type: AWS::Lambda::LayerVersion
@@ -2067,7 +2067,7 @@ Resources:
20672067
- LambdaLayerBucketPrefixIsManaged
20682068
- !FindInMap [RegionMap, !Ref 'AWS::Region', BucketName]
20692069
- !Sub '${LambdaLayerBucketPrefix}-${AWS::Region}' # Region added for backward compatibility
2070-
S3Key: 'cid-resource-lambda-layer/cid-4.1.0.zip' #replace version here if needed
2070+
S3Key: 'cid-resource-lambda-layer/cid-4.1.1.zip' #replace version here if needed
20712071
CompatibleRuntimes:
20722072
- python3.10
20732073
- python3.11

cid/_version.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
1-
__version__ = '4.1.0'
1+
__version__ = '4.1.1'
22

cid/helpers/quicksight/__init__.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1262,7 +1262,7 @@ def create_dashboard(self, definition: dict) -> Dashboard:
12621262
'VersionNumber': created_version
12631263
}
12641264
dashboard = self.describe_dashboard(poll=True, **describe_parameters)
1265-
self.set_tags(dashboard.arn, cid_version=dashboard.cid_version) # try to update version tag
1265+
self.set_tags(dashboard.arn, cid_version_tag=dashboard.cid_version) # try to update version tag
12661266

12671267
self.discover_dashboard(dashboard.id)
12681268
if not dashboard.health:
@@ -1335,7 +1335,6 @@ def update_dashboard(self, dashboard: Dashboard, definition):
13351335
updated_version = int(update_status['VersionArn'].split('/')[-1])
13361336

13371337
dashboard = self.describe_dashboard(poll=True, DashboardId=dashboard.id, VersionNumber=updated_version)
1338-
self.set_tags(dashboard.arn, cid_version=dashboard.cid_version) # try to update version tag
13391338

13401339
if not dashboard.health:
13411340
failure_reason = dashboard.version.get('Errors')
@@ -1350,6 +1349,7 @@ def update_dashboard(self, dashboard: Dashboard, definition):
13501349
logger.debug(result)
13511350
if result['Status'] != 200:
13521351
raise Exception(result)
1352+
self.set_tags(dashboard.arn, cid_version_tag=dashboard.latest_available_cid_version) # update version tag to the latest
13531353

13541354
return result
13551355

cid/helpers/quicksight/dashboard.py

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -215,7 +215,7 @@ def datasets(self):
215215
logger.debug(f'Access denied describing DataSetId {dataset_id} for Dashboard {self.id}')
216216
except self.qs.client.exceptions.InvalidParameterValueException:
217217
logger.debug(f'Invalid dataset {dataset_id}')
218-
logger.info(f"{self.name} has {len(self.datasets)} datasets")
218+
logger.info(f"{self.name} has {len(self._datasets)} datasets")
219219
return self._datasets
220220

221221
@property
@@ -248,7 +248,8 @@ def health(self) -> bool:
248248
def deployed_cid_version(self):
249249
if self._cid_version:
250250
return self._cid_version
251-
tag_version = (self.qs.get_tags(self.arn) or {}).get('cid_version')
251+
tag_version = (self.qs.get_tags(self.arn) or {}).get('cid_version_tag')
252+
#print(f'{self.id}: {tag_version}')
252253
if tag_version:
253254
logger.trace(f'version of {self.arn} from tag = {tag_version}')
254255
self._cid_version = CidVersion(tag_version)
@@ -258,8 +259,8 @@ def deployed_cid_version(self):
258259
elif self.deployed_definition:
259260
self._cid_version = self.deployed_definition.cid_version
260261
if self._cid_version:
261-
logger.trace(f'setting tag of {self.arn} to cid_version = {self._cid_version}')
262-
self.qs.set_tags(self.arn, cid_version=self._cid_version)
262+
logger.trace(f'setting tag of {self.arn} to cid_version_tag = {self._cid_version}')
263+
self.qs.set_tags(self.arn, cid_version_tag=self._cid_version)
263264
return self._cid_version
264265

265266

0 commit comments

Comments
 (0)