Commit ebd8086
committed
fix(web): align PublicationApprovalRequested publisher and schema
Two independent defects:
1. sendEvent() never called address.setStreet(), even though Property.getStreet() is available and the address schema requires 'street'. Every published event had an incomplete address.
2. The registered schema required contract, currency, and a string-typed listprice, but the publisher never set any of them (RequestApproval had no populated contract/currency fields and listprice was always null). Removed the three fields from both the publisher's event model and the registered schema, matching the canonical PublicationApprovalRequested contract already validated end-to-end in the .NET track (PropertyId, Status, Description, Images, Address{Country, City, Street, Number}). Also renamed the unused Address.state field to street and wired it up.
Verified: RequestApprovalFunctionTests and PublicationEvaluationEventHandlerTests (9/9) pass; sam validate --lint clean on the schema template.1 parent 28f6859 commit ebd8086
2 files changed
Lines changed: 6 additions & 41 deletions
File tree
- unicorn_web
- PublicationManagerService/src/main/java/publicationmanager
- infrastructure/schema-registry
Lines changed: 6 additions & 29 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
197 | 197 | | |
198 | 198 | | |
199 | 199 | | |
| 200 | + | |
200 | 201 | | |
201 | 202 | | |
202 | 203 | | |
203 | 204 | | |
204 | | - | |
205 | 205 | | |
206 | 206 | | |
207 | | - | |
208 | 207 | | |
209 | 208 | | |
210 | 209 | | |
| |||
242 | 241 | | |
243 | 242 | | |
244 | 243 | | |
245 | | - | |
246 | | - | |
247 | | - | |
248 | 244 | | |
249 | 245 | | |
250 | 246 | | |
251 | 247 | | |
252 | 248 | | |
253 | 249 | | |
254 | | - | |
255 | | - | |
256 | | - | |
257 | 250 | | |
258 | 251 | | |
259 | 252 | | |
| |||
278 | 271 | | |
279 | 272 | | |
280 | 273 | | |
281 | | - | |
282 | | - | |
283 | | - | |
284 | | - | |
285 | | - | |
286 | | - | |
287 | | - | |
288 | | - | |
289 | 274 | | |
290 | 275 | | |
291 | 276 | | |
| |||
301 | 286 | | |
302 | 287 | | |
303 | 288 | | |
304 | | - | |
305 | | - | |
306 | | - | |
307 | | - | |
308 | | - | |
309 | | - | |
310 | | - | |
311 | | - | |
312 | 289 | | |
313 | 290 | | |
314 | 291 | | |
315 | 292 | | |
316 | 293 | | |
317 | | - | |
| 294 | + | |
318 | 295 | | |
319 | 296 | | |
320 | 297 | | |
| |||
333 | 310 | | |
334 | 311 | | |
335 | 312 | | |
336 | | - | |
337 | | - | |
| 313 | + | |
| 314 | + | |
338 | 315 | | |
339 | 316 | | |
340 | | - | |
341 | | - | |
| 317 | + | |
| 318 | + | |
342 | 319 | | |
343 | 320 | | |
344 | 321 | | |
| |||
Lines changed: 0 additions & 12 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
89 | 89 | | |
90 | 90 | | |
91 | 91 | | |
92 | | - | |
93 | | - | |
94 | 92 | | |
95 | | - | |
96 | 93 | | |
97 | 94 | | |
98 | 95 | | |
99 | 96 | | |
100 | 97 | | |
101 | 98 | | |
102 | 99 | | |
103 | | - | |
104 | | - | |
105 | | - | |
106 | | - | |
107 | | - | |
108 | | - | |
109 | 100 | | |
110 | 101 | | |
111 | 102 | | |
| |||
115 | 106 | | |
116 | 107 | | |
117 | 108 | | |
118 | | - | |
119 | | - | |
120 | | - | |
121 | 109 | | |
122 | 110 | | |
123 | 111 | | |
| |||
0 commit comments