fix(mqtt): read and respect noProxyAddresses for mqtt connection (#1393)

Author: MikeDombo

src/main/java/com/aws/greengrass/mqttclient/MqttClient.java

@@ -36,6 +36,7 @@
 
 import java.io.Closeable;
 import java.time.Duration;
+import java.util.Arrays;
 import java.util.HashSet;
 import java.util.List;
 import java.util.Map;
@@ -185,8 +186,9 @@ public MqttClient(DeviceConfiguration deviceConfiguration, ScheduledExecutorServ
             } catch (MqttConnectionProviderException e) {
                 throw new MqttException(e.getMessage());
             }
+            String endpoint = Coerce.toString(deviceConfiguration.getIotDataEndpoint());
             builder.withCertificateAuthorityFromPath(null, Coerce.toString(deviceConfiguration.getRootCAFilePath()))
-                    .withEndpoint(Coerce.toString(deviceConfiguration.getIotDataEndpoint()))
+                    .withEndpoint(endpoint)
                     .withPort((short) Coerce.toInt(mqttTopics.findOrDefault(DEFAULT_MQTT_PORT, MQTT_PORT_KEY)))
                     .withCleanSession(false).withBootstrap(clientBootstrap).withKeepAliveMs(Coerce.toInt(
                             mqttTopics.findOrDefault(DEFAULT_MQTT_KEEP_ALIVE_TIMEOUT, MQTT_KEEP_ALIVE_TIMEOUT_KEY)))
@@ -195,9 +197,19 @@ public MqttClient(DeviceConfiguration deviceConfiguration, ScheduledExecutorServ
                             Coerce.toInt(mqttTopics.findOrDefault(DEFAULT_MQTT_PING_TIMEOUT, MQTT_PING_TIMEOUT_KEY)))
                     .withSocketOptions(new SocketOptions()).withTimeoutMs(Coerce.toInt(
                             mqttTopics.findOrDefault(DEFAULT_MQTT_SOCKET_TIMEOUT, MQTT_SOCKET_TIMEOUT_KEY)));
-            HttpProxyOptions httpProxyOptions = ProxyUtils.getHttpProxyOptions(deviceConfiguration, proxyTlsContext);
+
+            HttpProxyOptions httpProxyOptions =
+                    ProxyUtils.getHttpProxyOptions(deviceConfiguration, proxyTlsContext);
             if (httpProxyOptions != null) {
-                builder.withHttpProxyOptions(httpProxyOptions);
+                String noProxy = Coerce.toString(deviceConfiguration.getNoProxyAddresses());
+                boolean useProxy = true;
+                // Only use the proxy when the endpoint we're connecting to is not in the NoProxyAddress list
+                if (Utils.isNotEmpty(noProxy) && Utils.isNotEmpty(endpoint)) {
+                    useProxy = Arrays.stream(noProxy.split(",")).noneMatch(endpoint::matches);
+                }
+                if (useProxy) {
+                    builder.withHttpProxyOptions(httpProxyOptions);
+                }
             }
             return builder;
         };