add more logging

Author: patrick-ogrady

vm/verify_context.go

@@ -6,6 +6,7 @@ package vm
 import (
 	"context"
 	"errors"
+	"fmt"
 
 	"github.com/ava-labs/avalanchego/ids"
 	"github.com/ava-labs/avalanchego/utils/set"
@@ -86,7 +87,7 @@ func (a *AcceptedVerifyContext) View(ctx context.Context, blockRoot *ids.ID, _ b
 			// This should never happen but we check
 			// this to check subtle state handling bugs
 			// in the [chain] package.
-			return nil, ErrUnexpectedStateRoot
+			return nil, fmt.Errorf("%w: state=%s wanted=%s", ErrUnexpectedStateRoot, root, *blockRoot)
 		}
 	}
 	return state, nil

vm/vm.go

@@ -346,7 +346,8 @@ func (vm *VM) Initialize(
 		if err := sps.Commit(ctx); err != nil {
 			return err
 		}
-		if _, err := vm.stateDB.GetMerkleRoot(ctx); err != nil {
+		genesisRoot, err := vm.stateDB.GetMerkleRoot(ctx)
+		if err != nil {
 			snowCtx.Log.Error("could not get merkle root", zap.Error(err))
 			return err
 		}
@@ -359,7 +360,11 @@ func (vm *VM) Initialize(
 		}
 		gBlkID := genesisBlk.ID()
 		vm.preferred, vm.lastAccepted = gBlkID, genesisBlk
-		snowCtx.Log.Info("initialized vm from genesis", zap.Stringer("block", gBlkID))
+		snowCtx.Log.Info("initialized vm from genesis",
+			zap.Stringer("block", gBlkID),
+			zap.Stringer("pre-execution root", genesisBlk.StateRoot),
+			zap.Stringer("post-execution root", genesisRoot),
+		)
 	}
 	go vm.processAcceptedBlocks()