Skip to content

Commit 6fddd52

Browse files
committed
fixup: Avoid deploying service or ingress when inside the cluster
1 parent f5dbd59 commit 6fddd52

File tree

1 file changed

+10
-11
lines changed

1 file changed

+10
-11
lines changed

tests/fixture/tmpnet/kube_runtime.go

Lines changed: 10 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -316,19 +316,18 @@ func (p *KubeRuntime) Start(ctx context.Context) error {
316316
zap.String("statefulSet", statefulSetName),
317317
)
318318

319-
// Create Service for the node (prefix with 's-' for DNS compatibility)
320-
serviceName := "s-" + statefulSetName
321-
if err := p.createNodeService(ctx, serviceName); err != nil {
322-
return fmt.Errorf("failed to create Service for node: %w", err)
323-
}
319+
if !IsRunningInCluster() {
320+
// If running outside the cluster, ensure the node's API port is accessible via ingress
324321

325-
// Create Ingress for the node
326-
if err := p.createNodeIngress(ctx, serviceName); err != nil {
327-
return fmt.Errorf("failed to create Ingress for node: %w", err)
328-
}
322+
serviceName := "s-" + statefulSetName // The 's-' prefix ensures DNS compatibility
323+
if err := p.createNodeService(ctx, serviceName); err != nil {
324+
return fmt.Errorf("failed to create Service for node: %w", err)
325+
}
326+
327+
if err := p.createNodeIngress(ctx, serviceName); err != nil {
328+
return fmt.Errorf("failed to create Ingress for node: %w", err)
329+
}
329330

330-
// Wait for ingress to be ready if running outside cluster
331-
if !IsRunningInCluster() {
332331
if err := p.waitForIngressReadiness(ctx, serviceName); err != nil {
333332
return fmt.Errorf("failed to wait for Ingress readiness: %w", err)
334333
}

0 commit comments

Comments
 (0)