Skip to content

Commit 0b4f8ae

Browse files
committed
nit
Signed-off-by: Joshua Kim <[email protected]>
1 parent bec9405 commit 0b4f8ae

File tree

4 files changed

+8
-361
lines changed

4 files changed

+8
-361
lines changed

api/info/connect/info_connect.go renamed to api/info/connect/service.go

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ func (s *Service) GetNodeVersion(
3131
) (*connect.Response[infopb.GetNodeVersionResponse], error) {
3232
var jsonResponse info.GetNodeVersionReply
3333
if err := s.Info.GetNodeVersion(nil, nil, &jsonResponse); err != nil {
34-
return nil, err
34+
return nil, fmt.Errorf("failed to get node version: %w", err)
3535
}
3636

3737
vmVersions := make(map[string]string)
@@ -56,7 +56,7 @@ func (s *Service) GetNodeID(
5656
) (*connect.Response[infopb.GetNodeIDResponse], error) {
5757
var jsonResponse info.GetNodeIDReply
5858
if err := s.Info.GetNodeID(nil, nil, &jsonResponse); err != nil {
59-
return nil, err
59+
return nil, fmt.Errorf("failed to get node id: %w", err)
6060
}
6161

6262
response := &infopb.GetNodeIDResponse{
@@ -95,7 +95,7 @@ func (s *Service) GetNodeIP(
9595
) (*connect.Response[infopb.GetNodeIPResponse], error) {
9696
var jsonResponse info.GetNodeIPReply
9797
if err := s.Info.GetNodeIP(nil, nil, &jsonResponse); err != nil {
98-
return nil, err
98+
return nil, fmt.Errorf("failed to get node ip: %w", err)
9999
}
100100

101101
response := &infopb.GetNodeIPResponse{
@@ -111,7 +111,7 @@ func (s *Service) GetNetworkID(
111111
) (*connect.Response[infopb.GetNetworkIDResponse], error) {
112112
var jsonResponse info.GetNetworkIDReply
113113
if err := s.Info.GetNetworkID(nil, nil, &jsonResponse); err != nil {
114-
return nil, err
114+
return nil, fmt.Errorf("failed to get network id: %w", err)
115115
}
116116

117117
response := &infopb.GetNetworkIDResponse{
@@ -127,7 +127,7 @@ func (s *Service) GetNetworkName(
127127
) (*connect.Response[infopb.GetNetworkNameResponse], error) {
128128
var jsonResponse info.GetNetworkNameReply
129129
if err := s.Info.GetNetworkName(nil, nil, &jsonResponse); err != nil {
130-
return nil, err
130+
return nil, fmt.Errorf("failed to get network name: %w", err)
131131
}
132132

133133
response := &infopb.GetNetworkNameResponse{
@@ -149,7 +149,7 @@ func (s *Service) GetChainID(
149149
if err := s.Info.GetBlockchainID(nil,
150150
&jsonRequest,
151151
&jsonResponse); err != nil {
152-
return nil, err // todo error wrapping
152+
return nil, fmt.Errorf("failed to get blockchain id: %w", err)
153153
}
154154

155155
response := &infopb.GetChainIDResponse{
@@ -163,7 +163,7 @@ func (s *Service) GetPeers(
163163
_ context.Context,
164164
request *connect.Request[infopb.GetPeersRequest],
165165
) (*connect.Response[infopb.GetPeersResponse], error) {
166-
nodeIDs := make([]ids.NodeID, 0, len(request.Msg.NodeIds))
166+
nodeIDs := make([]ids.NodeID, len(request.Msg.NodeIds))
167167
for _, nodeIDStr := range request.Msg.NodeIds {
168168
nodeID, err := ids.NodeIDFromString(nodeIDStr)
169169
if err != nil {
@@ -216,7 +216,6 @@ func (s *Service) GetBootstrapped(
216216
_ context.Context,
217217
request *connect.Request[infopb.GetBootstrappedRequest],
218218
) (*connect.Response[infopb.GetBootstrappedResponse], error) {
219-
// Use the chain from the request
220219
jsonRequest := info.IsBootstrappedArgs{
221220
Chain: request.Msg.Chain,
222221
}

0 commit comments

Comments
 (0)