Skip to content

Conversation

@DanteNiewenhuis
Copy link
Contributor

@DanteNiewenhuis DanteNiewenhuis commented Nov 13, 2025

Summary

Fixed a bug in the creation of checkpoint snapshots that caused snapshots to become much larger than intended in specific scenarios.

Also updated the way fragments are handled to allow fragments with a duration of 0.

Added three new metrics for Tasks that measure the delay of a task caused by scheduling, failure, and checkpointing.

Implementation Notes ⚒️

Making snapshots in SimTraceWorkload now uses the same functions as OnUpdate to update the remaining work and time in the fragment.

External Dependencies 🍀

N / A

Breaking API Changes ⚠️

N / A

Simply specify none (N/A) if not applicable.

@DanteNiewenhuis DanteNiewenhuis self-assigned this Nov 13, 2025
@codecov
Copy link

codecov bot commented Nov 13, 2025

Codecov Report

❌ Patch coverage is 87.75510% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 57.44%. Comparing base (71f6361) to head (58b48c9).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...lator/compute/workload/trace/SimTraceWorkload.java 84.90% 3 Missing and 5 partials ⚠️
...mulator/telemetry/parquet/DfltTaskExportColumns.kt 75.00% 3 Missing ⚠️
.../opendc/compute/simulator/service/ServiceTask.java 83.33% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #380      +/-   ##
============================================
+ Coverage     57.36%   57.44%   +0.08%     
  Complexity        1        1              
============================================
  Files           335      335              
  Lines         10788    10826      +38     
  Branches       1037     1038       +1     
============================================
+ Hits           6188     6219      +31     
- Misses         4235     4240       +5     
- Partials        365      367       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@DanteNiewenhuis DanteNiewenhuis merged commit 90d4369 into atlarge-research:master Nov 13, 2025
5 checks passed
@DanteNiewenhuis DanteNiewenhuis deleted the adaptive-checkpoints branch November 13, 2025 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant