use local object, never typecast internal data

Author: mvorisek

demos/interactive/cardtable.php

@@ -12,4 +12,11 @@
 
 Header::addTo($app, ['Card displays read-only data of a single record']);
 
-CardTable::addTo($app)->setModel((new Stat($app->db))->loadAny());
+$entity = (new Stat($app->db))->loadAny();
+$entity->project_code .= ' <b>no reload</b>';
+
+CardTable::addTo($app)->setModel($entity);
+
+// CardTable uses internally atk4_local_object type which uses weak references,
+// force GC to test the data are kept referenced correctly
+gc_collect_cycles();

src/CardTable.php

@@ -4,6 +4,7 @@
 
 namespace Atk4\Ui;
 
+use Atk4\Data\Field;
 use Atk4\Data\Model;
 
 /**
@@ -34,12 +35,12 @@ public function setModel(Model $entity, array $columns = null): void
         }
 
         $data = [];
-        foreach ($entity->get() as $key => $value) {
+        foreach (array_keys($entity->get()) as $key) {
             if (in_array($key, $columns, true)) {
                 $data[] = [
                     'id' => $key,
                     'field' => $entity->getField($key)->getCaption(),
-                    'value' => $this->getApp()->uiPersistence->typecastSaveField($entity->getField($key), $value),
+                    'value' => new Model\EntityFieldPair($entity, $key),
                 ];
             }
         }
@@ -51,17 +52,13 @@ public function setModel(Model $entity, array $columns = null): void
             $this->_bypass = false;
         }
 
-        $this->addDecorator('value', [Table\Column\Multiformat::class, function (Model $row) use ($entity) {
-            $field = $entity->getField($row->getId());
-            $ret = $this->decoratorFactory(
-                $field,
-                $field->type === 'boolean' ? [Table\Column\Status::class, ['positive' => [true, 'Yes'], 'negative' => [false, 'No']]] : []
-            );
-            if ($ret instanceof Table\Column\Money) {
-                $ret->attr['all']['class'] = ['single line'];
+        $this->addDecorator('value', [Table\Column\Multiformat::class, function (Model $row, Field $field) {
+            $c = $this->decoratorFactory($field);
+            if ($c instanceof Table\Column\Money) {
+                $c->attr['all']['class'] = ['single line'];
             }
 
-            return [$ret];
+            return [$c];
         }]);
     }
 }

src/Table.php

@@ -7,6 +7,7 @@
 use Atk4\Core\Factory;
 use Atk4\Data\Field;
 use Atk4\Data\Model;
+use Atk4\Data\Model\EntityFieldPair;
 use Atk4\Ui\Js\Jquery;
 use Atk4\Ui\Js\JsChain;
 use Atk4\Ui\Js\JsExpression;
@@ -389,6 +390,40 @@ public function setModel(Model $model, array $columns = null): void
         }
     }
 
+    public function setSource(array $data, $fields = null): Model
+    {
+        // mainly for CardTable to support different field type for different row 1/2
+        // related with https://github.com/atk4/data/blob/4.0.0/tests/Persistence/StaticTest.php#L142
+        $dataWithObjects = [];
+        if (is_array(reset($data))) {
+            foreach ($data as $rowKey => $row) {
+                foreach ($row as $k => $v) {
+                    if ($v instanceof EntityFieldPair) {
+                        $dataWithObjects[$row['id']][$k] = $v;
+                        $data[$rowKey][$k] = null;
+                    }
+                }
+            }
+        }
+
+        $model = parent::setSource($data, $fields);
+
+        foreach ($dataWithObjects as $id => $row) {
+            $entity = $model->load($id);
+            foreach ($row as $k => $v) {
+                $model->getField($k)->type = 'atk4_local_object';
+                $entity->set($k, $v);
+            }
+            $entity->save();
+        }
+        $model->onHook(Model::HOOK_BEFORE_LOAD, function () use ($dataWithObjects) {
+            // useless hook, but make sure the $dataWithObjects is kept referenced from $model
+            $count = count($dataWithObjects);
+        });
+
+        return $model;
+    }
+
     protected function renderView(): void
     {
         if (!$this->columns) {
@@ -420,8 +455,26 @@ protected function renderView(): void
         // the same in Lister class
         $modelBackup = $this->model;
         try {
-            foreach ($this->model as $this->model) {
-                $this->currentRow = $this->model;
+            foreach ($this->model as $entityOrig) {
+                // mainly for CardTable to support different field type for different row 2/2
+                $entityCloned = (clone $entityOrig->getModel())->createEntity();
+                $entityCloned->setId($entityOrig->getId());
+                \Closure::bind(function () use ($entityOrig, $entityCloned) {
+                    foreach ($entityOrig->data as $k => $v) {
+                        $field = $entityCloned->getField($k);
+                        if ($field->type === 'atk4_local_object' && $v instanceof EntityFieldPair) {
+                            $field->type = $v->getField()->type;
+                            $field->enum = $v->getField()->enum;
+                            $field->values = $v->getField()->values;
+                            $field->ui = $v->getField()->ui;
+                            $v = $v->get();
+                        }
+                        $entityCloned->data[$k] = $v;
+                    }
+                }, null, Model::class)();
+
+                $this->model = $entityCloned;
+                $this->currentRow = $entityCloned; // TODO we should either drop currentRow property or never update model property
                 if ($this->hook(self::HOOK_BEFORE_ROW) === false) {
                     continue;
                 }