Fix form control lookup multiple initial value (#2278)

Author: mvorisek

demos/_unit-test/dropdown-html.php

@@ -17,6 +17,7 @@
 $htmlValues = [
     $makeTestStringFx('d') => $makeTestStringFx('dTitle'),
     $makeTestStringFx('u') => $makeTestStringFx('uTitle'),
+    $makeTestStringFx('v') => $makeTestStringFx('vTitle'),
     '[0 ]' => '[ ""]', // https://github.com/atk4/ui/pull/2274
 ];
 
@@ -105,8 +106,8 @@
     $form->entity->set(
         $k,
         str_contains($k, 'json')
-            ? [$makeTestStringFx('d')]
-            : $makeTestStringFx('d')
+            ? [$makeTestStringFx('d'), $makeTestStringFx('v')]
+            : $makeTestStringFx('d') . (str_contains($k, 'multi') ? ',' . $makeTestStringFx('v') : '')
     );
 }
 
@@ -126,7 +127,7 @@
     $view->invokeInit();
     $view->text->addParagraph($app->encodeJson($form->entity->get()));
     $view->text->addParagraph('match init: ' . ($form->entity->get() === $initData));
-    $view->text->addParagraph('match u add: ' . ($form->entity->get() === $makeExpectedDataFx(static fn ($k) => (str_contains($k, 'multi') ? $makeTestStringFx('d') . ',' : '') . $makeTestStringFx('u'))));
+    $view->text->addParagraph('match u add: ' . ($form->entity->get() === $makeExpectedDataFx(static fn ($k) => (str_contains($k, 'multi') ? $makeTestStringFx('d') . ',' . $makeTestStringFx('v') . ',' : '') . $makeTestStringFx('u'))));
     $view->text->addParagraph('match empty: ' . ($form->entity->get() === $makeExpectedDataFx(static fn () => '')));
     $view->text->addParagraph('match u only: ' . ($form->entity->get() === $makeExpectedDataFx(static fn () => $makeTestStringFx('u'))));
     $view->text->addParagraph('match json-like add: ' . ($form->entity->get() === $makeExpectedDataFx(static fn ($k) => (str_contains($k, 'multi') ? $makeTestStringFx('u') . ',' : '') . '[0 ]')));

src/Form/Control/Dropdown.php

@@ -109,7 +109,7 @@ public function getInputValue(): ?string
         // dropdown input tag accepts CSV formatted list of IDs
         return $this->entityField !== null
             ? ($this->multiple && $this->entityField->getField()->type === 'json' && is_array($this->entityField->get())
-                ? implode(', ', $this->entityField->get())
+                ? implode(',', $this->entityField->get())
                 : $this->getApp()->uiPersistence->typecastAttributeSaveField($this->entityField->getField(), $this->entityField->get()))
             : parent::getInputValue();
     }

src/Form/Control/Lookup.php

@@ -146,7 +146,7 @@ public function getInputValue(): ?string
         // dropdown input tag accepts CSV formatted list of IDs
         return $this->entityField !== null
             ? ($this->multiple && $this->entityField->getField()->type === 'json' && is_array($this->entityField->get())
-                ? implode(', ', $this->entityField->get())
+                ? implode(',', $this->entityField->get())
                 : $this->getApp()->uiPersistence->typecastAttributeSaveField($this->entityField->getField(), $this->entityField->get()))
             : parent::getInputValue();
     }
@@ -385,10 +385,15 @@ protected function initDropdown($jsChain): void
 
             foreach ($this->model->createIteratorBy(
                 $idField,
-                $this->multiple && $this->entityField->getField()->type === 'json' && is_array($this->entityField->get())
+                $this->multiple
                     ? 'in'
                     : '=',
-                $this->entityField->get()
+                $this->multiple && !($this->entityField->getField()->type === 'json' && is_array($this->entityField->get()))
+                    ? array_map(
+                        fn ($v) => $this->model->getPersistence()->typecastLoadField($this->entityField->getField(), $v),
+                        explode(',', $this->model->getPersistence()->typecastSaveField($this->entityField->getField(), $this->entityField->get()))
+                    )
+                    : $this->entityField->get()
             ) as $entity) {
                 $settings['values'][] = array_merge($this->renderRow($entity), ['selected' => true]);
             }