Do not mutate App::$request during testing (#2111)

Author: mvorisek

demos/_unit-test/sse.php

@@ -15,7 +15,7 @@
 $v = View::addTo($app)->set('This will trigger a network request for testing SSE...');
 
 $sse = JsSse::addTo($app);
-// URL trigger must match php_unit test in sse provider.
+// URL trigger must match phpunit test in SSE provider
 $sse->setUrlTrigger('see_test');
 
 $v->js(true, $sse->set(static function () use ($sse) {

demos/basic/button.php

@@ -15,14 +15,12 @@
 /** @var \Atk4\Ui\App $app */
 require_once __DIR__ . '/../init-app.php';
 
-// Demonstrates how to use buttons.
-
 Header::addTo($app, ['Basic Button', 'size' => 2]);
 
-// With Seed
+// with seed
 Button::addTo($app, ['Click me'])->link(['index']);
 
-// Without Seeding
+// without seeding
 $b1 = new Button('Click me (no seed)');
 $app->add($b1);
 // must be added first

demos/collection/card-deck.php

@@ -27,7 +27,7 @@
     },
 ]);
 
-// Create custom button for this action in card.
+// create custom button for this action in card
 $app->getExecutorFactory()->registerTrigger(ExecutorFactory::CARD_BUTTON, [Button::class, 'class.blue' => true, 'icon' => 'plane'], $action);
 
 $action->args = [

demos/collection/crud.php

@@ -22,12 +22,12 @@
 
 $crud = Crud::addTo($app, ['ipp' => 10]);
 
-// callback for model action add form.
+// callback for model action add form
 $crud->onFormAdd(static function (Form $form, ModalExecutor $ex) use ($model) {
     $form->js(true, $form->getControl($model->fieldName()->name)->jsInput()->val('Entering value via javascript'));
 });
 
-// callback for model action edit form.
+// callback for model action edit form
 $crud->onFormEdit(static function (Form $form) use ($model) {
     $form->js(true, $form->getControl($model->fieldName()->name)->jsInput()->attr('readonly', true));
 });
@@ -51,7 +51,7 @@
     'menu' => ['class' => ['green inverted']],
     'table' => ['class' => ['red inverted']],
 ]);
-// Condition on the model can be applied on a model
+// condition on the model can be applied on a model
 $model = new Country($app->db);
 $model->addCondition($model->fieldName()->numcode, '<', 200);
 $model->onHook(Model::HOOK_VALIDATE, static function (Country $model, ?string $intent) {
@@ -64,7 +64,7 @@
 });
 $crud->setModel($model);
 
-// Because Crud inherits Grid, you can also define custom actions
+// because Crud inherits Grid, you can also define custom actions
 $crud->addModalAction(['icon' => 'cogs'], 'Details', static function (View $p, $id) use ($crud) {
     $model = Country::assertInstanceOf($crud->model);
     Message::addTo($p, ['Details for: ' . $model->load($id)->name . ' (id: ' . $id . ')']);
@@ -102,6 +102,6 @@ public function addFormTo(View $view): Form
 
 $crud->menu->addItem(['Rescan', 'icon' => 'recycle']);
 
-// Condition on the model can be applied after setting the model
+// condition on the model can be applied after setting the model
 $crud->setModel($file);
 $file->addCondition($file->fieldName()->parent_folder_id, null);

demos/collection/crud3.php

@@ -27,7 +27,7 @@ protected function init(): void
     }
 });
 
-// Prepare Persistence and data Model
+// prepare Persistence and data Model
 $data = ['test' => [
     1 => ['id' => 1, 'name' => 'ABC9', 'code' => 11, 'country' => 'Ireland'],
     2 => ['id' => 2, 'name' => 'ABC8', 'code' => 12, 'country' => 'Ireland'],

demos/collection/grid.php

@@ -36,7 +36,7 @@
     'nameField' => $model->fieldName()->name,
 ]);
 
-// Adding Quicksearch on Name field using auto query.
+// adding Quicksearch on Name field using auto query
 $grid->addQuickSearch([$model->fieldName()->name], true);
 
 if ($grid->stickyGet('no-ajax')) {
@@ -49,7 +49,7 @@
 
 $grid->addColumn(null, [Table\Column\Template::class, 'hello<b>world</b>']);
 
-// Creating a button for executing model test user action.
+// creating a button for executing model test user action
 $grid->addExecutorButton($grid->getExecutorFactory()->createExecutor($model->getUserAction('test'), $grid));
 
 $grid->addActionButton('Say HI', static function (Jquery $j, $id) use ($grid) {
@@ -62,7 +62,7 @@
     Message::addTo($p, ['Clicked on ID=' . $id]);
 });
 
-// Creating an executor for delete action.
+// creating an executor for delete action
 $deleteExecutor = $grid->getExecutorFactory()->createExecutor($model->getUserAction('delete'), $grid);
 $deleteExecutor->onHook(BasicExecutor::HOOK_AFTER_EXECUTE, static function () {
     return [
@@ -79,7 +79,7 @@
     return new JsToast('Selected: ' . implode(', ', $ids) . '#');
 });
 
-// Executing a modal on a bulk selection
+// executing a modal on a bulk selection
 $grid->addModalBulkAction(['Delete selected', 'icon' => 'trash'], '', static function (View $modal, array $ids) use ($grid) {
     Message::addTo($modal, [
         'The selected records will be permanently deleted: ' . implode(', ', $ids) . '#',
@@ -103,5 +103,5 @@
     });
 });
 
-// Setting ipp with an array will add an ItemPerPageSelector to paginator.
+// setting ipp with an array will add an ItemPerPageSelector to paginator
 $grid->setIpp([10, 100, 1000]);

demos/collection/multitable.php

@@ -17,7 +17,7 @@
 /** @var \Atk4\Ui\App $app */
 require_once __DIR__ . '/../init-app.php';
 
-// Re-usable component implementing counter
+// re-usable component implementing counter
 
 $finderClass = AnonymousClassNameCache::get_class(fn () => new class() extends Columns {
     public array $route = [];

demos/collection/tablecolumnmenu.php

@@ -16,15 +16,15 @@
 
 Header::addTo($app, ['Table column may contains popup or dropdown menu.']);
 
-// Better Popup positioning when Popup are inside a container.
+// better Popup positioning when Popup are inside a container
 $container = View::addTo($app, ['ui' => 'vertical segment']);
 $table = Table::addTo($container, ['class.celled' => true]);
 $table->setModel(new SomeData(), []);
 
-// will add popup to this column.
+// will add popup to this column
 $colName = $table->addColumn('name');
 
-// will add dropdown menu to this column.
+// will add dropdown menu to this column
 $colSurname = $table->addColumn('surname');
 
 $colTitle = $table->addColumn('title');
@@ -36,7 +36,7 @@
 Text::addTo($colName->addPopup())->set('Name popup');
 
 // dynamic popup setup
-// This popup will add content using the callback function.
+// this popup will add content using the callback function
 $colSurname->addPopup()->set(static function (View $pop) {
     Text::addTo($pop)->set('This popup is loaded dynamically');
 });
@@ -50,16 +50,16 @@
 
 Header::addTo($app, ['Grid column may contains popup or dropdown menu.']);
 
-// Table in Grid are already inside a container.
+// Table in Grid are already inside a container
 $grid = Grid::addTo($app);
 $grid->setModel(new Country($app->db));
 $grid->ipp = 5;
 
-// Adding a dropdown menu to the column 'name'.
+// adding a dropdown menu to the column 'name'
 $grid->addDropdown(Country::hinting()->fieldName()->name, ['Rename', 'Delete'], static function (string $item) {
     return $item;
 });
 
-// Adding a popup view to the column 'iso'
+// adding a popup view to the column 'iso'
 $pop = $grid->addPopup(Country::hinting()->fieldName()->iso);
 Text::addTo($pop)->set('Grid column popup');

demos/collection/tablefilter.php

@@ -10,10 +10,9 @@
 /** @var \Atk4\Ui\App $app */
 require_once __DIR__ . '/../init-app.php';
 
-// For popup positioning to work correctly, table needs to be inside a view segment.
+// for popup positioning to work correctly, table needs to be inside a view segment
 $view = View::addTo($app, ['ui' => 'basic segment']);
-// Important: menu class added for Behat testing.
-$grid = Grid::addTo($view, ['menu' => ['class' => ['atk-grid-menu']]]);
+$grid = Grid::addTo($view, ['menu' => ['class' => ['atk-grid-menu']]]); // menu class added for Behat testing
 
 $model = new Country($app->db);
 $model->addExpression('is_uk', [

demos/data-action/actions.php

@@ -22,7 +22,7 @@
     // Which fields may be edited for the action. Default to all fields.
     // ModalExecutor for example, will only display fields set in this array.
     'fields' => [$files->fieldName()->name],
-    // callback function to call in model when action execute.
+    // Callback function to call in model when action execute.
     // Can use a closure function or model method.
     'callback' => 'importFromFilesystem',
     // Some Ui action executor will use this property for displaying text in button.