From ad0d1d8929cc1075e46cfeae0d8ac46a5219d0bd Mon Sep 17 00:00:00 2001 From: Julian Vennen Date: Thu, 18 Dec 2025 11:14:56 +0100 Subject: [PATCH 1/2] Return true when deleting an object that does not exist in opensearch driver --- src/Driver/OpenSearch/OpenSearch.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Driver/OpenSearch/OpenSearch.php b/src/Driver/OpenSearch/OpenSearch.php index 30bebef..909a2f8 100644 --- a/src/Driver/OpenSearch/OpenSearch.php +++ b/src/Driver/OpenSearch/OpenSearch.php @@ -178,7 +178,7 @@ public function delete(ModelInterface $model): bool ); } catch (HttpErrorResponseException $e) { if ($e->getCode() === 404) { - return false; + return true; } throw $e; } From 97efeaeb5a5d8f40936941c96018dc2c59ce4679 Mon Sep 17 00:00:00 2001 From: Julian Vennen Date: Thu, 18 Dec 2025 11:17:09 +0100 Subject: [PATCH 2/2] Just use the default return --- src/Driver/OpenSearch/OpenSearch.php | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/Driver/OpenSearch/OpenSearch.php b/src/Driver/OpenSearch/OpenSearch.php index 909a2f8..6db43f7 100644 --- a/src/Driver/OpenSearch/OpenSearch.php +++ b/src/Driver/OpenSearch/OpenSearch.php @@ -177,10 +177,9 @@ public function delete(ModelInterface $model): bool $this->buildUrl($model::getName(), "_doc", $model->getId()) ); } catch (HttpErrorResponseException $e) { - if ($e->getCode() === 404) { - return true; + if ($e->getCode() !== 404) { + throw $e; } - throw $e; } return true;