diff --git a/benchmarks/RemoteBenchmark/Node1/Node1.csproj b/benchmarks/RemoteBenchmark/Node1/Node1.csproj index ea3a0bd633..e35e99907b 100644 --- a/benchmarks/RemoteBenchmark/Node1/Node1.csproj +++ b/benchmarks/RemoteBenchmark/Node1/Node1.csproj @@ -15,7 +15,8 @@ - - NETCORE + + + $(DefineConstants);NETCORE diff --git a/benchmarks/RemoteBenchmark/Node1/context.md b/benchmarks/RemoteBenchmark/Node1/context.md index 8a3243995c..ece535f5d4 100644 --- a/benchmarks/RemoteBenchmark/Node1/context.md +++ b/benchmarks/RemoteBenchmark/Node1/context.md @@ -6,7 +6,7 @@ Primary node for remote benchmark harness. _Parent context: [Remote Benchmark](../context.md)_ ## Key Files -* `Node1.csproj` – Project file configuring compilation targets and dependencies. +* `Node1.csproj` – Project file configuring compilation targets and dependencies, now defining the `NETCORE` compilation constant for the .NET 8 build explicitly. * `Program.cs` – C# source defining Program behavior. ## Primary Types and Contracts diff --git a/benchmarks/RemoteBenchmark/Node2/Node2.csproj b/benchmarks/RemoteBenchmark/Node2/Node2.csproj index d5bc79e534..5d69ba25d9 100644 --- a/benchmarks/RemoteBenchmark/Node2/Node2.csproj +++ b/benchmarks/RemoteBenchmark/Node2/Node2.csproj @@ -14,7 +14,8 @@ - - NETCORE + + + $(DefineConstants);NETCORE diff --git a/benchmarks/RemoteBenchmark/Node2/context.md b/benchmarks/RemoteBenchmark/Node2/context.md index 46dc4847f2..5c4e319d41 100644 --- a/benchmarks/RemoteBenchmark/Node2/context.md +++ b/benchmarks/RemoteBenchmark/Node2/context.md @@ -6,7 +6,7 @@ Secondary node for remote benchmark harness. _Parent context: [Remote Benchmark](../context.md)_ ## Key Files -* `Node2.csproj` – Project file configuring compilation targets and dependencies. +* `Node2.csproj` – Project file configuring compilation targets and dependencies, explicitly adding the `NETCORE` define for the .NET 8 target. * `Program.cs` – C# source defining Program behavior. ## Primary Types and Contracts diff --git a/examples/cluster.aspnet-grains/Node1/Node1.csproj b/examples/cluster.aspnet-grains/Node1/Node1.csproj index a500b5238e..cca38032cf 100644 --- a/examples/cluster.aspnet-grains/Node1/Node1.csproj +++ b/examples/cluster.aspnet-grains/Node1/Node1.csproj @@ -14,9 +14,7 @@ - - ..\..\..\..\..\..\.nuget\packages\stackexchange.redis\2.6.111\lib\net5.0\StackExchange.Redis.dll - + diff --git a/examples/cluster.aspnet-grains/Node1/context.md b/examples/cluster.aspnet-grains/Node1/context.md index 66f709dc36..860216eb09 100644 --- a/examples/cluster.aspnet-grains/Node1/context.md +++ b/examples/cluster.aspnet-grains/Node1/context.md @@ -6,7 +6,7 @@ Node1 directory within the Proto.Actor repository. _Parent context: [Cluster Aspnet Grains](../context.md)_ ## Key Files -* `Node1.csproj` – Project file configuring compilation targets and dependencies. +* `Node1.csproj` – Project file configuring compilation targets and dependencies, including a .NET 8 StackExchange.Redis package reference. * `Program.cs` – C# source defining Program behavior. * `appsettings.Development.json` – Configuration or metadata in JSON format. * `appsettings.json` – Configuration or metadata in JSON format. diff --git a/examples/cluster.aspnet-grains/Node2/Node2.csproj b/examples/cluster.aspnet-grains/Node2/Node2.csproj index 1efecc0456..140f8d1e10 100644 --- a/examples/cluster.aspnet-grains/Node2/Node2.csproj +++ b/examples/cluster.aspnet-grains/Node2/Node2.csproj @@ -13,7 +13,7 @@ - + diff --git a/examples/cluster.aspnet-grains/Node2/context.md b/examples/cluster.aspnet-grains/Node2/context.md index d8d21fb289..0fad584d4e 100644 --- a/examples/cluster.aspnet-grains/Node2/context.md +++ b/examples/cluster.aspnet-grains/Node2/context.md @@ -7,7 +7,7 @@ _Parent context: [Cluster Aspnet Grains](../context.md)_ ## Key Files * `HelloGrain.cs` – C# source defining Hello Grain behavior. -* `Node2.csproj` – Project file configuring compilation targets and dependencies. +* `Node2.csproj` – Project file configuring compilation targets and dependencies, pulling StackExchange.Redis through the .NET 8 package feed. * `Program.cs` – C# source defining Program behavior. * `appsettings.Development.json` – Configuration or metadata in JSON format. * `appsettings.json` – Configuration or metadata in JSON format. diff --git a/logs/exceptions.md b/logs/exceptions.md index acd895af65..74fedf4a21 100644 --- a/logs/exceptions.md +++ b/logs/exceptions.md @@ -58,3 +58,6 @@ Proto.TestKit.TestKitException : Waited 1 seconds but failed to receive a messag ### Proto.Cluster.Tests.GossipCoreTests.Large_cluster_should_get_topology_consensus `Expected x.consensus to be True, but found False.` occurred twice before extending the consensus timeout to 20 seconds. + +### Proto.Tests.SharedFutureTests.Should_wrap_request_ids_without_hitting_zero +`Expected future.Pid.RequestId to be 8u, but found 1u.` observed when verifying request id wrap-around on .NET 8 after the upgrade; focused rerun and a full-suite retry passed. diff --git a/tests/Proto.Remote.Tests/Proto.Remote.Tests.csproj b/tests/Proto.Remote.Tests/Proto.Remote.Tests.csproj index 174a822ccc..a1fa8218e4 100644 --- a/tests/Proto.Remote.Tests/Proto.Remote.Tests.csproj +++ b/tests/Proto.Remote.Tests/Proto.Remote.Tests.csproj @@ -11,7 +11,8 @@ - - NETCORE + + + $(DefineConstants);NETCORE diff --git a/tests/Proto.Remote.Tests/context.md b/tests/Proto.Remote.Tests/context.md index 1e2e44e24c..01a0f8f785 100644 --- a/tests/Proto.Remote.Tests/context.md +++ b/tests/Proto.Remote.Tests/context.md @@ -12,7 +12,7 @@ _Parent context: [Tests](../context.md)_ * `EchoActor.cs` – C# source defining Echo Actor behavior. * `ForcedSerializationTests.cs` – C# source defining Forced Serialization Tests behavior. * `LargeMessageEnvelopeTests.cs` – C# source defining Large Message Envelope Tests behavior. -* `Proto.Remote.Tests.csproj` – Project file configuring compilation targets and dependencies. +* `Proto.Remote.Tests.csproj` – Project file configuring compilation targets and dependencies, including the explicit .NET 8 `NETCORE` compilation constant. * `RemoteFixture.cs` – C# source defining Remote Fixture behavior, including descriptor helpers for composing test transport combinations and unified startup/disposal logic. * `RemoteKindsRegistrationTests.cs` – C# source defining Remote Kinds Registration Tests behavior. * `RemoteStreamProcessorTests.cs` – C# source defining Remote Stream Processor Tests behavior.