Skip to content

Conversation

@TenzDelek
Copy link
Contributor

Description
created storybook for cards

  1. Venue
Screenshot 2025-10-05 at 12 00 08 PM
  1. Speaker
Screenshot 2025-10-05 at 11 59 57 AM
  1. past-edition
Screenshot 2025-10-05 at 12 00 03 PM

Related issue(s)

GSOC

@netlify
Copy link

netlify bot commented Oct 5, 2025

Deploy Preview for peaceful-ramanujan-288045 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit a3c8947
🔍 Latest deploy log https://app.netlify.com/projects/peaceful-ramanujan-288045/deploys/6915f7d95c004e000878f2ab
😎 Deploy Preview https://deploy-preview-811--peaceful-ramanujan-288045.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Member

@AceTheCreator AceTheCreator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

think we might need to rethink this card Storybook setup. The current approach treats stories as one-to-one with use cases, but they should really map one-to-one with components.

I understand your reasoning, since we have three card implementations, that’s three separate components, each with its own story file. But that separation should be because they’re technically different components, not because of different use cases.

A better approach would be to create a single, flexible Card component with variants that cover all three cases. The goal of a design system is to capture patterns and build reusable solutions. If every use case becomes its own component, we lose that consistency and end up with a collection of one-offs.

Great work so far 💪🏽
Let me know what you think, @TenzDelek.

cc @ashmit-coder

@TenzDelek
Copy link
Contributor Author

TenzDelek commented Oct 18, 2025

think we might need to rethink this card Storybook setup. The current approach treats stories as one-to-one with use cases, but they should really map one-to-one with components.

I understand your reasoning, since we have three card implementations, that’s three separate components, each with its own story file. But that separation should be because they’re technically different components, not because of different use cases.

A better approach would be to create a single, flexible Card component with variants that cover all three cases. The goal of a design system is to capture patterns and build reusable solutions. If every use case becomes its own component, we lose that consistency and end up with a collection of one-offs.

Great work so far 💪🏽 Let me know what you think, @TenzDelek.

cc @ashmit-coder

Thank you Ace for your suggestion but I think forcing those card into one component would be the wrong kind of abstraction and would be much harder to maintain in the long run. there will be unnecessary to much of prop passing and conditional.
I think instead of that, we can go with similar case of how shadcn does. using a base card component (kind of a wrapper).
cc @AceTheCreator @ashmit-coder

@AceTheCreator
Copy link
Member

think we might need to rethink this card Storybook setup. The current approach treats stories as one-to-one with use cases, but they should really map one-to-one with components.
I understand your reasoning, since we have three card implementations, that’s three separate components, each with its own story file. But that separation should be because they’re technically different components, not because of different use cases.
A better approach would be to create a single, flexible Card component with variants that cover all three cases. The goal of a design system is to capture patterns and build reusable solutions. If every use case becomes its own component, we lose that consistency and end up with a collection of one-offs.
Great work so far 💪🏽 Let me know what you think, @TenzDelek.
cc @ashmit-coder

Thank you Ace for your suggestion but I think forcing those card into one component would be the wrong kind of abstraction and would be much harder to maintain in the long run. there will be unnecessary to much of prop passing and conditional. I think instead of that, we can go with similar case of how shadcn does. using a base card component (kind of a wrapper). cc @AceTheCreator @ashmit-coder

@TenzDelek can you share a link on how shadcn does it?

@TenzDelek
Copy link
Contributor Author

think we might need to rethink this card Storybook setup. The current approach treats stories as one-to-one with use cases, but they should really map one-to-one with components.
I understand your reasoning, since we have three card implementations, that’s three separate components, each with its own story file. But that separation should be because they’re technically different components, not because of different use cases.
A better approach would be to create a single, flexible Card component with variants that cover all three cases. The goal of a design system is to capture patterns and build reusable solutions. If every use case becomes its own component, we lose that consistency and end up with a collection of one-offs.
Great work so far 💪🏽 Let me know what you think, @TenzDelek.
cc @ashmit-coder

Thank you Ace for your suggestion but I think forcing those card into one component would be the wrong kind of abstraction and would be much harder to maintain in the long run. there will be unnecessary to much of prop passing and conditional. I think instead of that, we can go with similar case of how shadcn does. using a base card component (kind of a wrapper). cc @AceTheCreator @ashmit-coder

@TenzDelek can you share a link on how shadcn does it?

https://ui.shadcn.com/docs/components/card cc @AceTheCreator

@TenzDelek
Copy link
Contributor Author

hi @AceTheCreator ,@ashmit-coder , I went through the codebase of the main website. and it seems they are also keeping it in a distributive way. I think this would be much approachable and cleaner than what you suggested. because thinking in another way all three card seems to be way different in terms of ui. but happy to hear what your thought on this one as well. 😄
prev gsoc pr related with it asyncapi/website#3122

@AceTheCreator
Copy link
Member

hi @AceTheCreator ,@ashmit-coder , I went through the codebase of the main website. and it seems they are also keeping it in a distributive way. I think this would be much approachable and cleaner than what you suggested. because thinking in another way all three card seems to be way different in terms of ui. but happy to hear what your thought on this one as well. 😄 prev gsoc pr related with it asyncapi/website#3122

Okay, let's do it that way then 👍🏾

@TenzDelek
Copy link
Contributor Author

hi @AceTheCreator ,@ashmit-coder , I went through the codebase of the main website. and it seems they are also keeping it in a distributive way. I think this would be much approachable and cleaner than what you suggested. because thinking in another way all three card seems to be way different in terms of ui. but happy to hear what your thought on this one as well. 😄 prev gsoc pr related with it asyncapi/website#3122

Okay, let's do it that way then 👍🏾

this pr is already doing that. happy for a quick review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants