-
-
Notifications
You must be signed in to change notification settings - Fork 171
feat: card Storybook Components #811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for peaceful-ramanujan-288045 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
AceTheCreator
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
think we might need to rethink this card Storybook setup. The current approach treats stories as one-to-one with use cases, but they should really map one-to-one with components.
I understand your reasoning, since we have three card implementations, that’s three separate components, each with its own story file. But that separation should be because they’re technically different components, not because of different use cases.
A better approach would be to create a single, flexible Card component with variants that cover all three cases. The goal of a design system is to capture patterns and build reusable solutions. If every use case becomes its own component, we lose that consistency and end up with a collection of one-offs.
Great work so far 💪🏽
Let me know what you think, @TenzDelek.
Thank you Ace for your suggestion but I think forcing those card into one component would be the wrong kind of abstraction and would be much harder to maintain in the long run. there will be unnecessary to much of prop passing and conditional. |
@TenzDelek can you share a link on how shadcn does it? |
https://ui.shadcn.com/docs/components/card cc @AceTheCreator |
|
hi @AceTheCreator ,@ashmit-coder , I went through the codebase of the main website. and it seems they are also keeping it in a distributive way. I think this would be much approachable and cleaner than what you suggested. because thinking in another way all three card seems to be way different in terms of ui. but happy to hear what your thought on this one as well. 😄 |
Okay, let's do it that way then 👍🏾 |
this pr is already doing that. happy for a quick review. |
Description
created storybook for cards
Related issue(s)
GSOC