-
-
Notifications
You must be signed in to change notification settings - Fork 171
fix: keep closed tickets visible at the bottom with disabled styling #808
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: keep closed tickets visible at the bottom with disabled styling #808
Conversation
✅ Deploy Preview for peaceful-ramanujan-288045 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
AceTheCreator
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don’t think the online ticket should display ended unless the event date is actually in the past 🤔
Also, it might be better not to show the online ticket at all, since it’s free and online, the ticket component doesn’t really add much value.
should i mark it "Disabled "? |
I feel "closed" works better |
…github/conference-website into tickets-closed-visibility
marked as "closed" |
AceTheCreator
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀
Fixes #807
This PR improves the Tickets section by keeping closed tickets visible instead of removing them entirely.
Tickets are now sorted so that upcoming/current tickets appear first and closed tickets appear at the bottom.
Closed tickets display a red “Ended” badge.
The “Get a Ticket” button is shown but disabled with the label “Event Ended.”
Closed tickets remain consistent in appearance with active tickets, ensuring a clean UI.
This provides a consistent carousel experience while clearly indicating which tickets are no longer available.
Before:
Closed tickets were completely hidden.
Inconsistent user experience.
After:
Closed tickets remain visible.
Red badge + disabled button show event is ended.