Skip to content

Conversation

@harshhgithub
Copy link
Contributor

Fixes #807
This PR improves the Tickets section by keeping closed tickets visible instead of removing them entirely.
Tickets are now sorted so that upcoming/current tickets appear first and closed tickets appear at the bottom.
Closed tickets display a red “Ended” badge.
The “Get a Ticket” button is shown but disabled with the label “Event Ended.”
Closed tickets remain consistent in appearance with active tickets, ensuring a clean UI.
This provides a consistent carousel experience while clearly indicating which tickets are no longer available.

Before:
Closed tickets were completely hidden.
Inconsistent user experience.

After:
Closed tickets remain visible.
Red badge + disabled button show event is ended.

Screenshot (893)

@netlify
Copy link

netlify bot commented Sep 26, 2025

Deploy Preview for peaceful-ramanujan-288045 ready!

Name Link
🔨 Latest commit 3545d1f
🔍 Latest deploy log https://app.netlify.com/projects/peaceful-ramanujan-288045/deploys/68f366815542a60008b3927f
😎 Deploy Preview https://deploy-preview-808--peaceful-ramanujan-288045.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Member

@AceTheCreator AceTheCreator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don’t think the online ticket should display ended unless the event date is actually in the past 🤔

Also, it might be better not to show the online ticket at all, since it’s free and online, the ticket component doesn’t really add much value.

@harshhgithub
Copy link
Contributor Author

I don’t think the online ticket should display ended unless the event date is actually in the past 🤔

Also, it might be better not to show the online ticket at all, since it’s free and online, the ticket component doesn’t really add much value.

should i mark it "Disabled "?

@AceTheCreator
Copy link
Member

I don’t think the online ticket should display ended unless the event date is actually in the past 🤔
Also, it might be better not to show the online ticket at all, since it’s free and online, the ticket component doesn’t really add much value.

should i mark it "Disabled "?

I feel "closed" works better

@harshhgithub
Copy link
Contributor Author

I don’t think the online ticket should display ended unless the event date is actually in the past 🤔
Also, it might be better not to show the online ticket at all, since it’s free and online, the ticket component doesn’t really add much value.

should i mark it "Disabled "?

I feel "closed" works better

marked as "closed"

Copy link
Member

@AceTheCreator AceTheCreator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@AceTheCreator AceTheCreator merged commit ef36bd6 into asyncapi:master Oct 18, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ticket section UX Issue

2 participants