Skip to content

[Feature] Clean MoSDeN for Initial Release #38

@LukeSeifert

Description

@LukeSeifert

Is your feature request related to a problem? Please describe.

MoSDeN has several issues that should be cleaned up before the initial release.

Describe the feature you'd like.

  • JSON sensitivity reading is excessively slow; replace with HDF5 or some other data format
  • Add tests for chemical removal expected behavior
  • Remove various hard-coded values
  • Give each unique DNP its own color
  • Use the scientific Python dev guide
  • Store literature data externally in CSVs
  • Reduce code repetition (base.py can do more heavy lifting)

Optional features

  • Add automated documentation
  • Add more unit tests for better coverage
  • Reduce function sizes and make stateless
  • Remove typing except for in function definitions and return statements

How can this issue be closed?

All non-optional features are added

Sub-issues

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions