Skip to content

issue with :left-join, missing ::expr-list spec #3

@mladvladimir

Description

@mladvladimir

Hi,
If I try to evaluate i.e.

(s/explain 
  ::left-join 
  '[:left-join 
    [:bgp [?s ?p ?o]]
    [:bgp [?s :rdf/type ?type]]
   true])

I've got:
Exception Unable to resolve spec: :arachne.aristotle.query.spec/expr-list clojure.spec.alpha/reg-resolve! (alpha.clj:69)

Probably in ::left-join spec need to put:

(s/cat :op #{:left-join} :left ::operation :right ::operation
         :exprs (s/+ ::expr)))

instead of:

(s/cat :op #{:left-join} :left ::operation :right ::operation
         :exprs (s/+ ::expr-list)))

Awesome lib, BTW! :)

Regards

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions