persistent option flag may doesn't work

[Pueringni3]

Description

This is my first time reporting a bug on GitHub Discussions. Please let me know if I've made any mistakes.

I found typo when reading the trivy source code.
https://github.com/aquasecurity/trivy/blob/main/pkg/flag/options.go#L319-L323

First, it checks if f == nil:

	if f == nil {
		return nil
	}

But later, it checks if f == nil again
(maybe this is typo ( f -> flag )

if f == nil {

Desired Behavior

	flag := cmd.Flags().Lookup(f.Name)
	if flag == nil {
		// Lookup local persistent flags
		flag = cmd.PersistentFlags().Lookup(f.Name)
	}

Actual Behavior

	flag := cmd.Flags().Lookup(f.Name)
	if f == nil {
		// Lookup local persistent flags
		flag = cmd.PersistentFlags().Lookup(f.Name)
	}

Reproduction Steps

I just found typo. I didn't trigger this bug.

Target

None

Scanner

None

Output Format

None

Mode

None

Debug Output

None

Operating System

None

Version

None

Checklist

• Run trivy clean --all
• Read the troubleshooting

[simar7]

hi @Pueringni3 nice catch! That does indeed look like a bug/typo to me. Would you like to create a PR to fix it?

[Pueringni3]

@simar7
I created PR for fixing this. Please review the change. thank you.
#9374