TestTLSRegistry Integration test on mac m1 do not pass

[nikpivkin]

TestTLSRegistry integration test fails on mac m1:

go test -v pkg/fanal/test/integration/registry_test.go
=== RUN   TestTLSRegistry
Testcontainers properties file has been found: /Users/tososomaru/.testcontainers.properties
2023/06/06 14:25:58 github.com/testcontainers/testcontainers-go - Connected to docker: 
  Server Version: 23.0.5
  API Version: 1.42
  Operating System: Docker Desktop
  Total Memory: 3933 MB
2023/06/06 14:25:58 🐳 Creating container for image docker.io/testcontainers/ryuk:0.4.0
2023/06/06 14:25:58 ✅ Container created: fed0a68f2611
2023/06/06 14:25:58 🐳 Starting container: fed0a68f2611
2023/06/06 14:25:59 🚧 Waiting for container id fed0a68f2611 image: docker.io/testcontainers/ryuk:0.4.0
2023/06/06 14:25:59 ✅ Container started: fed0a68f2611
2023/06/06 14:25:59 🐳 Creating container for image registry:2
2023/06/06 14:25:59 ✅ Container created: b15a45da61f4
2023/06/06 14:25:59 🐳 Starting container: b15a45da61f4
2023/06/06 14:25:59 🚧 Waiting for container id b15a45da61f4 image: registry:2
2023/06/06 14:25:59 ✅ Container started: b15a45da61f4
=== RUN   TestTLSRegistry/happy_path
    registry_test.go:187: 
                Error Trace:    /Users/tososomaru/projects/trivy/pkg/fanal/test/integration/registry_test.go:187
                Error:          Not equal: 
                                expected: false
                                actual  : true
                Test:           TestTLSRegistry/happy_path
                Messages:       2 errors occurred:
                                        * GET https://localhost:52279/v2/ghcr.io/aquasecurity/trivy-test-images/manifests/alpine-310: MANIFEST_UNKNOWN: manifest unknown; map[Tag:alpine-310]
                                        * GET https://localhost:52279/v2/ghcr.io/aquasecurity/trivy-test-images/manifests/alpine-310: UNAUTHORIZED: authentication required; [map[Action:pull Class: Name:ghcr.io/aquasecurity/trivy-test-images Type:repository]]
                            
=== RUN   TestTLSRegistry/happy_path_with_docker_login
    registry_test.go:179: 
                Error Trace:    /Users/tososomaru/projects/trivy/pkg/fanal/test/integration/registry_test.go:179
                Error:          Received unexpected error:
                                exit status 1
                Test:           TestTLSRegistry/happy_path_with_docker_login
=== RUN   TestTLSRegistry/sad_path:_tls_verify
=== RUN   TestTLSRegistry/sad_path:_no_credential
2023/06/06 14:26:01 🐳 Terminating container: b15a45da61f4
2023/06/06 14:26:01 🚫 Container terminated: b15a45da61f4
--- FAIL: TestTLSRegistry (3.02s)
    --- FAIL: TestTLSRegistry/happy_path (0.54s)
    --- FAIL: TestTLSRegistry/happy_path_with_docker_login (0.30s)
    --- PASS: TestTLSRegistry/sad_path:_tls_verify (0.52s)
    --- PASS: TestTLSRegistry/sad_path:_no_credential (0.60s)
FAIL
FAIL    command-line-arguments  4.057s
FAIL

What could be the problem?

ProductName:		macOS
ProductVersion:		13.3.1

[knqyf263]

Thanks for reporting. Any ideas as to the cause of the error?

[nikpivkin]

@knqyf263 executing image push fails:

{"status":"The push refers to repository [localhost:64844/ghcr.io/aquasecurity/trivy-test-images]"}
{"errorDetail":{"message":"Get \"http://localhost:64844/v2/\": dial tcp [::1]:64844: connect: connection refused"},"error":"Get \"http://localhost:64844/v2/\": dial tcp [::1]:64844: connect: connection refused"}

but when I change localhost to 0.0.0.0 and try to push the image myself, I get the following

> docker tag alpine 0.0.0.0:64907/ghcr.io/aquasecurity/trivy-test-images:alpine-310
> docker push 0.0.0.0:64907/ghcr.io/aquasecurity/trivy-test-images:alpine-310
The push refers to repository [0.0.0.0:64907/ghcr.io/aquasecurity/trivy-test-images]
Get "https://0.0.0.0:64907/v2/": x509: certificate has expired or is not yet valid: current time 2023-06-07T11:27:40Z is after 2020-10-12T17:22:10Z

Next I added the following to /etc/docker/daemon.json:

"insecure-registries": [
    "0.0.0.0/1",
  ]

and was able to successfully push the image to the registry using 0.0.0.0 ip

[knqyf263]

0.0.0.0 looks really weird. Can't we go with localhost somehow?