Add tests for USimpleString (KF-31, #72)

belyshevdenis · Copilot · SergiusTheBest · web-flow · commit 4b1238185392 · 2025-11-05T18:47:33.000+02:00
* implement tests for USimpleString

* implement tests for USimpleString

* Apply suggestion from @Copilot

Co-authored-by: Copilot &lt;175728472+Copilot@users.noreply.github.com&gt;

* Apply suggestion from @Copilot

Co-authored-by: Copilot &lt;175728472+Copilot@users.noreply.github.com&gt;

* Remove extra .string()

---------

Co-authored-by: Copilot &lt;175728472+Copilot@users.noreply.github.com&gt;
Co-authored-by: Sergey Podobry &lt;sergius@apriorit.com&gt;
diff --git a/include/kf/USimpleString.h b/include/kf/USimpleString.h
@@ -334,7 +334,11 @@ namespace kf
         return const_cast<USimpleString*>(this)->end();
     }
 
-    // Comparison
+    // Comparison return code meaning:
+    // Return code	Description
+    // 0: this equals str
+    // <0: this is less than str
+    // >0: this is greater than str
     inline int USimpleString::compareTo(_In_ const UNICODE_STRING& str) const
     {
         return ::RtlCompareUnicodeString(&m_str, &str, FALSE);
@@ -375,11 +379,13 @@ namespace kf
         return equalsIgnoreCase(str.string());
     }
 
+    // Case sensitive lexicographical comparison
     inline bool USimpleString::operator<(_In_ const USimpleString& another) const
     {
         return compareTo(another) < 0;
     }
 
+    // Case sensitive lexicographical comparison
     inline bool USimpleString::operator==(_In_ const USimpleString& another) const
     {
         return equals(another);
diff --git a/test/CMakeLists.txt b/test/CMakeLists.txt
@@ -59,6 +59,7 @@ wdk_add_driver(kf-test WINVER NTDDI_WIN10 STL
     AutoSpinLockTest.cpp
     EResourceSharedLockTest.cpp
     RecursiveAutoSpinLockTest.cpp
+    USimpleStringTest.cpp
 )
 
 target_link_libraries(kf-test kf::kf kmtest::kmtest)
diff --git a/test/USimpleStringTest.cpp b/test/USimpleStringTest.cpp

Original file line number	Diff line number	Diff line change
`@@ -334,7 +334,11 @@ namespace kf`
`334`	`334`	`return const_cast<USimpleString*>(this)->end();`
`335`	`335`	`}`
`336`	`336`
`337`		`- // Comparison`
	`337`	`+ // Comparison return code meaning:`
	`338`	`+ // Return code Description`
	`339`	`+ // 0: this equals str`
	`340`	`+ // <0: this is less than str`
	`341`	`+ // >0: this is greater than str`
`338`	`342`	`inline int USimpleString::compareTo(_In_ const UNICODE_STRING& str) const`
`339`	`343`	`{`
`340`	`344`	`return ::RtlCompareUnicodeString(&m_str, &str, FALSE);`
`@@ -375,11 +379,13 @@ namespace kf`
`375`	`379`	`return equalsIgnoreCase(str.string());`
`376`	`380`	`}`
`377`	`381`
	`382`	`+ // Case sensitive lexicographical comparison`
`378`	`383`	`inline bool USimpleString::operator<(_In_ const USimpleString& another) const`
`379`	`384`	`{`
`380`	`385`	`return compareTo(another) < 0;`
`381`	`386`	`}`
`382`	`387`
	`388`	`+ // Case sensitive lexicographical comparison`
`383`	`389`	`inline bool USimpleString::operator==(_In_ const USimpleString& another) const`
`384`	`390`	`{`
`385`	`391`	`return equals(another);`
Original file line number	Diff line number	Diff line change
`@@ -59,6 +59,7 @@ wdk_add_driver(kf-test WINVER NTDDI_WIN10 STL`
`59`	`59`	`AutoSpinLockTest.cpp`
`60`	`60`	`EResourceSharedLockTest.cpp`
`61`	`61`	`RecursiveAutoSpinLockTest.cpp`
	`62`	`+ USimpleStringTest.cpp`
`62`	`63`	`)`
`63`	`64`
`64`	`65`	`target_link_libraries(kf-test kf::kf kmtest::kmtest)`