Support for 64-bit timespec seconds on 32-bit platforms #3277
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lukasa
reviewed
Jun 29, 2025
| #else | ||
| let tvSec = curTime.tv_sec + Int((allNSecs / nsecPerSec)) | ||
| #endif | ||
| let tvSec = curTime.tv_sec + _Seconds((allNSecs / nsecPerSec)) |
There was a problem hiding this comment.
I'm inclined to assume that we could actually just make this time_t on all platforms.
| let nsecPerSec: Int64 = 1_000_000_000 | ||
| let ns = amount.nanoseconds | ||
| let sec = ns / nsecPerSec | ||
| self = timespec(tv_sec: Int(sec), tv_nsec: Int(ns - sec * nsecPerSec)) | ||
| self = timespec(tv_sec: _Seconds(sec), tv_nsec: Int(ns - sec * nsecPerSec)) |
There was a problem hiding this comment.
Similarly, I'm inclined to assume we could just make this a time_t on all platforms.
Modern 32-bit platforms (such as embedded Linux builds) support 64-bit timestamps in time_t and timespec.
lhoward
force-pushed
the
64bit-time_t-on-32bit-platforms
branch
from
c50e12d to
a143444
Compare
Lukasa
approved these changes
Jun 30, 2025
|
Thanks for this! ✨ |
|
Great! Out of interest, what's the release cadence of swift-nio? Curious when we can enable 64-bit timestamps in the Yocto layer. |
|
I expect we'll be able to release this week. |
|
Shipped as 2.84.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modern 32-bit platforms (such as embedded Linux builds) support 64-bit timestamps in
time_tandtimespec. Accommodate this.