Refactor generator settings loading and decoding logic to use switch statements for improved readability and maintainability. (#186)

Author: kasugamirai

cmd/pkl-gen-go/pkl-gen-go.go

@@ -287,11 +287,12 @@ func loadGeneratorSettings(cmd *cobra.Command) (generatorsettings.GeneratorSetti
 		panic(err)
 	}
 	var source *pkl.ModuleSource
-	if generatorSettingsPath != "" {
+	switch {
+	case generatorSettingsPath != "":
 		source = pkl.FileSource(generatorSettingsPath)
-	} else if fileExists("generator-settings.pkl") {
+	case fileExists("generator-settings.pkl"):
 		source = pkl.FileSource("generator-settings.pkl")
-	} else {
+	default:
 		source = generatorSettingsSource()
 	}
 	s, err := generatorsettings.Load(context.Background(), evaluator, source)

pkl/decode_struct.go

@@ -268,11 +268,12 @@ func (d *decoder) decodeStructField(fields map[string]structField, out *reflect.
 	}
 	decodedType := decodedValue.Type()
 	field := out.FieldByName(sf.Name)
-	if decodedType.AssignableTo(field.Type()) {
+	switch {
+	case decodedType.AssignableTo(field.Type()):
 		field.Set(*decodedValue)
-	} else if decodedType.ConvertibleTo(field.Type()) {
+	case decodedType.ConvertibleTo(field.Type()):
 		field.Set(field.Convert(field.Type()))
-	} else {
+	default:
 		return fmt.Errorf("unable to assign or convert value for property `%s` of type `%s` to field `%s.%s` of type `%s`", propertyName, decodedType.String(), out.Type().String(), sf.Name, field.Type().String())
 	}
 	return d.skip(length - 3)

pkl/decoder.go

@@ -140,11 +140,12 @@ func (d *decoder) decodePointer(inType reflect.Type) (*reflect.Value, error) {
 		return val, nil
 	}
 	ret := reflect.New(inType.Elem())
-	if val.Type().AssignableTo(ret.Elem().Type()) {
+	switch {
+	case val.Type().AssignableTo(ret.Elem().Type()):
 		ret.Elem().Set(*val)
-	} else if val.Type().ConvertibleTo(ret.Elem().Type()) {
+	case val.Type().ConvertibleTo(ret.Elem().Type()):
 		ret.Elem().Set(val.Convert(ret.Elem().Type()))
-	} else {
+	default:
 		return nil, fmt.Errorf("unable to assign or convert value of type `%s` to pointer of type `%s`", val.Type(), ret.Type())
 	}
 	return &ret, nil