Provide encryption support with fdbbackup modify command #12554

akankshamahajan15 · 2025-11-14T19:24:05Z

Provide encryption support with fdbbackup modify command
to address issue #12544

In fdbbackup modify command, user need to pass --encryption-key-file along with new url to encrypt the backup data.

NOTE: encryption key can be changed for modify backup command (if new url is passed) and during restore of that new location backup, same encryption key needs to be provided. In short, encryption keys needs to be matched for backup and restore.

Steps to reproduce mentioned in #12544 (comment)

Testing

Create a local cluster locally and fill it with some data.
Create continous backup with encryption location: backup_before :
fdbbackup start -C /root/local_testing/loopback-cluster/fdb.cluster -t mybackup -d file:///root/local_testing/backup_before/ --encryption-key-file /root/local_testing/key_file --no-stop-when-done -s 60 --log --logdir=/root/local_testing/logs

fdbbackup describe -C /root/local_testing/loopback-cluster/fdb.cluster -d file:///root/local_testing/backup_before/backup-2025-11-14-17-57-26.435329/
URL: file:///root/local_testing/backup_before/backup-2025-11-14-17-57-26.435329/
Restorable: true
Partitioned logs: false
File-level encryption: true
Snapshot:  startVersion=470115248 (maxLogEnd -0.00 days)  endVersion=470129700 (maxLogEnd -0.00 days)  totalBytes=3522  restorable=true  expiredPct=0.00
Snapshot:  startVersion=498539321 (maxLogEnd -0.00 days)  endVersion=505119005 (maxLogEnd -0.00 days)  totalBytes=3522  restorable=true  expiredPct=0.00
Snapshot:  startVersion=534294465 (maxLogEnd -0.00 days)  endVersion=564215364 (maxLogEnd -0.00 days)  totalBytes=3522  restorable=true  expiredPct=0.00
Snapshot:  startVersion=580132893 (maxLogEnd -0.00 days)  endVersion=613091670 (maxLogEnd -0.00 days)  totalBytes=3522  restorable=true  expiredPct=0.00
Snapshot:  startVersion=630167378 (maxLogEnd -0.00 days)  endVersion=656536792 (maxLogEnd -0.00 days)  totalBytes=3522  restorable=true  expiredPct=0.00
Snapshot:  startVersion=667896844 (maxLogEnd -0.00 days)  endVersion=674118020 (maxLogEnd -0.00 days)  totalBytes=3522  restorable=true  expiredPct=0.00
SnapshotBytes: 21132
MinLogBeginVersion:      470091871 (maxLogEnd -0.00 days)
ContiguousLogEndVersion: 690091871 (maxLogEnd -0.00 days)
MaxLogEndVersion:        690091871 (maxLogEnd -0.00 days)
MinRestorableVersion:    470129700 (maxLogEnd -0.00 days)
MaxRestorableVersion:    690091870 (maxLogEnd -0.00 days)

While backup is running, modify the url to backup_after and provide encryption key
fdbbackup modify -C /root/local_testing/loopback-cluster/fdb.cluster -t mybackup -d file:///root/local_testing/backup_after/ --encryption-key-file /root/local_testing/key_file --log --logdir=/root/local_testing/logs
For new backup location:

fdbbackup describe -C /root/local_testing/loopback-cluster/fdb.cluster -d file:///root/local_testing/backup_after/
URL: file:///root/local_testing/backup_after/
Restorable: true
Partitioned logs: false
File-level encryption: true
Snapshot:  startVersion=789290679 (maxLogEnd -0.00 days)  endVersion=827810911 (maxLogEnd -0.00 days)  totalBytes=3522  restorable=false  expiredPct=0.00
Snapshot:  startVersion=854212454 (maxLogEnd -0.00 days)  endVersion=886700930 (maxLogEnd -0.00 days)  totalBytes=3522  restorable=true  expiredPct=0.00
SnapshotBytes: 7044
MinLogBeginVersion:      810091871 (maxLogEnd -0.00 days)
ContiguousLogEndVersion: 910091871 (maxLogEnd -0.00 days)
MaxLogEndVersion:        910091871 (maxLogEnd -0.00 days)
MinRestorableVersion:    886700930 (maxLogEnd -0.00 days)
MaxRestorableVersion:    910091870 (maxLogEnd -0.00 days)

Now during restore
6.1 If wrong key is provided for backup_after

fdbrestore start --dest-cluster-file /root/local_testing/loopback-cluster/fdb.cluster -t mybackup -w -r file:///root/local_testing/backup_after/ --log --logdir=/root/local_testing/logs --encryption-key-file /root/local_testing/wrong_key
No restore target version given, will use maximum restorable version from backup description.
Using target restore version 910091870
Backup Description
URL: file:///root/local_testing/backup_after/
Restorable: true
Partitioned logs: false
File-level encryption: true
Snapshot:  startVersion=789290679 (maxLogEnd -0.00 days)  endVersion=827810911 (maxLogEnd -0.00 days)  totalBytes=3522  restorable=false  expiredPct=0.00
Snapshot:  startVersion=854212454 (maxLogEnd -0.00 days)  endVersion=886700930 (maxLogEnd -0.00 days)  totalBytes=3522  restorable=true  expiredPct=0.00
SnapshotBytes: 7044
UnreliableEndVersion:    0 (maxLogEnd -0.01 days)
MinLogBeginVersion:      810091871 (maxLogEnd -0.00 days)
ContiguousLogEndVersion: 910091871 (maxLogEnd -0.00 days)
MaxLogEndVersion:        910091871 (maxLogEnd -0.00 days)
MinRestorableVersion:    886700930 (maxLogEnd -0.00 days)
MaxRestorableVersion:    910091870 (maxLogEnd -0.00 days)
ERROR: Failed to read data. Verify that backup and restore encryption keys match (if provided) or the data is corrupted.
ERROR: Restore error
Fatal Error: Restore error

6.2 If same encryption key is provided for backup_after

fdbrestore start --dest-cluster-file /root/local_testing/loopback-cluster/fdb.cluster -t mybackup -w -r file:///root/local_testing/backup_after/ --log --logdir=/root/local_testing/logs --encryption-key-file /root/local_testing/key_file
No restore target version given, will use maximum restorable version from backup description.
Using target restore version 910091870
Backup Description
URL: file:///root/local_testing/backup_after/
Restorable: true
Partitioned logs: false
File-level encryption: true
Snapshot:  startVersion=789290679 (maxLogEnd -0.00 days)  endVersion=827810911 (maxLogEnd -0.00 days)  totalBytes=3522  restorable=false  expiredPct=0.00
Snapshot:  startVersion=854212454 (maxLogEnd -0.00 days)  endVersion=886700930 (maxLogEnd -0.00 days)  totalBytes=3522  restorable=true  expiredPct=0.00
SnapshotBytes: 7044
UnreliableEndVersion:    0 (maxLogEnd -0.01 days)
MinLogBeginVersion:      810091871 (maxLogEnd -0.00 days)
ContiguousLogEndVersion: 910091871 (maxLogEnd -0.00 days)
MaxLogEndVersion:        910091871 (maxLogEnd -0.00 days)
MinRestorableVersion:    886700930 (maxLogEnd -0.00 days)
MaxRestorableVersion:    910091870 (maxLogEnd -0.00 days)
Restoring backup to version: 910091870
Tag: mybackup  UID: 9f620f4cf5dbc222a1cf2725ec3899b0  State: queued  Blocks: 0/0  BlocksInProgress: 0  Files: 0  BytesWritten: 0  ApplyVersionLag: 0  LastError: None
Tag: mybackup  UID: 9f620f4cf5dbc222a1cf2725ec3899b0  State: starting  Blocks: 0/0  BlocksInProgress: 0  Files: 0  BytesWritten: 0  ApplyVersionLag: 0  LastError: None
Tag: mybackup  UID: 9f620f4cf5dbc222a1cf2725ec3899b0  State: running  Blocks: 0/3  BlocksInProgress: 3  Files: 6  BytesWritten: 0  ApplyVersionLag: 0  LastError: None
Tag: mybackup  UID: 9f620f4cf5dbc222a1cf2725ec3899b0  State: completed  Blocks: 3/3  BlocksInProgress: 0  Files: 6  BytesWritten: 2600  ApplyVersionLag: 0  LastError: None
Restored to version 910091870

Completed 100k simulation test -

20251114-195339-akankshamahajan-a2de62864f86153e compressed=True data_size=38554198 duration=4754822 ended=100000 fail_fast=10 max_runs=100000 pass=100000 priority=100 remaining=0 runtime=1:15:54 sanity=False started=100000 stopped=20251114-210933 submitted=20251114-195339 timeout=5400 username=akankshamahajan

foundationdb-ci · 2025-11-14T19:28:31Z

Result of foundationdb-pr-clang-ide on Linux RHEL 9

Commit ID: d48bcad
Duration 0:04:16
Result: ❌ FAILED
Error: Error while executing command: if [[ $(git diff --shortstat 2> /dev/null | tail -n1) == "" ]]; then echo "CODE FORMAT CLEAN"; else echo "CODE FORMAT NOT CLEAN"; echo; echo "THE FOLLOWING FILES NEED TO BE FORMATTED"; echo; git ls-files -m; echo; if [[ $FDB_VERSION =~ 7\.\3. ]]; then echo skip; else exit 1; fi; fi. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2025-11-14T19:28:34Z

Result of foundationdb-pr-clang-arm on Linux CentOS 7

Commit ID: d48bcad
Duration 0:04:20
Result: ❌ FAILED
Error: Error while executing command: if [[ $(git diff --shortstat 2> /dev/null | tail -n1) == "" ]]; then echo "CODE FORMAT CLEAN"; else echo "CODE FORMAT NOT CLEAN"; echo; echo "THE FOLLOWING FILES NEED TO BE FORMATTED"; echo; git ls-files -m; echo; if [[ $FDB_VERSION =~ 7\.\3. ]]; then echo skip; else exit 1; fi; fi. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2025-11-14T19:28:42Z

Result of foundationdb-pr-cluster-tests on Linux RHEL 9

Commit ID: d48bcad
Duration 0:04:26
Result: ❌ FAILED
Error: Error while executing command: if [[ $(git diff --shortstat 2> /dev/null | tail -n1) == "" ]]; then echo "CODE FORMAT CLEAN"; else echo "CODE FORMAT NOT CLEAN"; echo; echo "THE FOLLOWING FILES NEED TO BE FORMATTED"; echo; git ls-files -m; echo; if [[ $FDB_VERSION =~ 7\.\3. ]]; then echo skip; else exit 1; fi; fi. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)
Cluster Test Logs zip file of the test logs (available for 30 days)

foundationdb-ci · 2025-11-14T19:28:43Z

Result of foundationdb-pr on Linux RHEL 9

Commit ID: d48bcad
Duration 0:04:27
Result: ❌ FAILED
Error: Error while executing command: if [[ $(git diff --shortstat 2> /dev/null | tail -n1) == "" ]]; then echo "CODE FORMAT CLEAN"; else echo "CODE FORMAT NOT CLEAN"; echo; echo "THE FOLLOWING FILES NEED TO BE FORMATTED"; echo; git ls-files -m; echo; if [[ $FDB_VERSION =~ 7\.\3. ]]; then echo skip; else exit 1; fi; fi. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2025-11-14T19:29:19Z

Result of foundationdb-pr-clang on Linux RHEL 9

Commit ID: d48bcad
Duration 0:05:01
Result: ❌ FAILED
Error: Error while executing command: if [[ $(git diff --shortstat 2> /dev/null | tail -n1) == "" ]]; then echo "CODE FORMAT CLEAN"; else echo "CODE FORMAT NOT CLEAN"; echo; echo "THE FOLLOWING FILES NEED TO BE FORMATTED"; echo; git ls-files -m; echo; if [[ $FDB_VERSION =~ 7\.\3. ]]; then echo skip; else exit 1; fi; fi. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

akankshamahajan15 · 2025-11-14T19:37:47Z

NOTE: If snapshot interval is changed, then encryption key doesn't need to provide because container will not open. Container is created only when destination is changed, so encryption key needs to be provided for that.

fdbbackup status -C  /root/local_testing/loopback-cluster/fdb.cluster -t mybackup
The backup on tag `mybackup' is restorable but continuing to file:///root/local_testing/backup_before/backup-2025-11-14-19-29-18.808351.
BackupUID: c62b623c2776f11879ecbff603cb03db
BackupURL: file:///root/local_testing/backup_before/backup-2025-11-14-19-29-18.808351
Snapshot interval is 240 seconds.  Current snapshot progress target is 41.49% (>100% means the snapshot is supposed to be done)

Details:
 LogBytes written - 0
 RangeBytes written - 17640
 Last complete log version and timestamp        - 2532622317, 2025/11/14.19:34:00+0000
 Last complete snapshot version and timestamp   - 2449166256, 2025/11/14.19:32:36+0000
 Current Snapshot start version and timestamp   - 2449180112, 2025/11/14.19:32:36+0000
 Expected snapshot end version and timestamp    - 2689180112, 2025/11/14.19:36:37+0000
 Backup supposed to stop at next snapshot completion - No

Changed snapshot interval to 60 to 240 during modify command and backup is encrypted.

foundationdb-ci · 2025-11-14T19:49:58Z

Result of foundationdb-pr-clang on Linux RHEL 9

Commit ID: d03a905
Duration 0:04:21
Result: ❌ FAILED
Error: Error while executing command: if [[ $(git diff --shortstat 2> /dev/null | tail -n1) == "" ]]; then echo "CODE FORMAT CLEAN"; else echo "CODE FORMAT NOT CLEAN"; echo; echo "THE FOLLOWING FILES NEED TO BE FORMATTED"; echo; git ls-files -m; echo; if [[ $FDB_VERSION =~ 7\.\3. ]]; then echo skip; else exit 1; fi; fi. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2025-11-14T19:49:58Z

Result of foundationdb-pr-clang-ide on Linux RHEL 9

Commit ID: d03a905
Duration 0:04:23
Result: ❌ FAILED
Error: Error while executing command: if [[ $(git diff --shortstat 2> /dev/null | tail -n1) == "" ]]; then echo "CODE FORMAT CLEAN"; else echo "CODE FORMAT NOT CLEAN"; echo; echo "THE FOLLOWING FILES NEED TO BE FORMATTED"; echo; git ls-files -m; echo; if [[ $FDB_VERSION =~ 7\.\3. ]]; then echo skip; else exit 1; fi; fi. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2025-11-14T19:50:00Z

Result of foundationdb-pr-cluster-tests on Linux RHEL 9

Commit ID: d03a905
Duration 0:04:23
Result: ❌ FAILED
Error: Error while executing command: if [[ $(git diff --shortstat 2> /dev/null | tail -n1) == "" ]]; then echo "CODE FORMAT CLEAN"; else echo "CODE FORMAT NOT CLEAN"; echo; echo "THE FOLLOWING FILES NEED TO BE FORMATTED"; echo; git ls-files -m; echo; if [[ $FDB_VERSION =~ 7\.\3. ]]; then echo skip; else exit 1; fi; fi. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)
Cluster Test Logs zip file of the test logs (available for 30 days)

foundationdb-ci · 2025-11-14T19:50:14Z

Result of foundationdb-pr on Linux RHEL 9

Commit ID: d03a905
Duration 0:04:39
Result: ❌ FAILED
Error: Error while executing command: if [[ $(git diff --shortstat 2> /dev/null | tail -n1) == "" ]]; then echo "CODE FORMAT CLEAN"; else echo "CODE FORMAT NOT CLEAN"; echo; echo "THE FOLLOWING FILES NEED TO BE FORMATTED"; echo; git ls-files -m; echo; if [[ $FDB_VERSION =~ 7\.\3. ]]; then echo skip; else exit 1; fi; fi. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2025-11-14T19:50:26Z

Result of foundationdb-pr-clang-arm on Linux CentOS 7

Commit ID: d03a905
Duration 0:04:50
Result: ❌ FAILED
Error: Error while executing command: if [[ $(git diff --shortstat 2> /dev/null | tail -n1) == "" ]]; then echo "CODE FORMAT CLEAN"; else echo "CODE FORMAT NOT CLEAN"; echo; echo "THE FOLLOWING FILES NEED TO BE FORMATTED"; echo; git ls-files -m; echo; if [[ $FDB_VERSION =~ 7\.\3. ]]; then echo skip; else exit 1; fi; fi. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2025-11-14T20:01:53Z

Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x

Commit ID: d48bcad
Duration 0:37:37
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2025-11-14T20:17:39Z

Result of foundationdb-pr-macos on macOS Ventura 13.x

Commit ID: d48bcad
Duration 0:53:23
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2025-11-14T22:28:43Z

Result of foundationdb-pr-clang-ide on Linux RHEL 9

Commit ID: 3217796
Duration 0:26:10
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2025-11-14T22:42:08Z

Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x

Commit ID: 3217796
Duration 0:39:36
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2025-11-14T22:47:33Z

Result of foundationdb-pr-clang-arm on Linux CentOS 7

Commit ID: 3217796
Duration 0:45:00
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2025-11-14T22:57:47Z

Result of foundationdb-pr on Linux RHEL 9

Commit ID: 3217796
Duration 0:55:09
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2025-11-14T22:58:27Z

Result of foundationdb-pr-macos on macOS Ventura 13.x

Commit ID: 3217796
Duration 0:55:54
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2025-11-14T22:59:45Z

Result of foundationdb-pr-clang on Linux RHEL 9

Commit ID: 3217796
Duration 0:57:09
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2025-11-14T23:11:13Z

Result of foundationdb-pr-cluster-tests on Linux RHEL 9

Commit ID: 3217796
Duration 1:08:38
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)
Cluster Test Logs zip file of the test logs (available for 30 days)

neethuhaneesha · 2025-11-17T18:16:18Z

fdbclient/BackupContainerFileSystem.actor.cpp

 		Optional<Version> existingEncryptionMetadata = wait(bc->fileLevelEncryption().get());

 		if (!existingEncryptionMetadata.present()) {
+			bool exists = wait(bc->exists());


What is the case where bc does not exist?

This is bit tricky.

I wanted to create FileLevelEncryption file in properties if a url is modify so that when fdbbackup describe is called, it shows the file level encryption information.

But for Local Directory, directory/backup container is not created during create but when files are actually written.
This is not the case with S3
So there is no way (this is what I understand) to create encryption metadata file unless I create when backup files are written/created and add check (if encryption property metadata exist, skip). But I wanted to avoid that check for so many files.

This is not the case with backup submit because in backup submit I added the check on finish task when backups are ready to start and there is no duplication.
But no such thing is there in backup modify. Url is changed and config is updated and backup agents just pick up the task and start writing (with updating url).

Hope it makes sense! Let me know, I can go over the code as well.

fdbbackup/backup.actor.cpp

foundationdb-ci · 2025-11-17T22:02:57Z

Result of foundationdb-pr-clang-ide on Linux RHEL 9

Commit ID: 0f2b559
Duration 0:15:24
Result: ❌ FAILED
Error: Error while executing command: ninja -v -C build_output -j ${NPROC} all. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2025-11-17T22:18:47Z

Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x

Commit ID: 0f2b559
Duration 0:31:14
Result: ❌ FAILED
Error: Error while executing command: ssh -o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null -i ${HOME}/.ssh_key ec2-user@${MAC_EC2_HOST} /opt/homebrew/bin/bash --login -c ./build_pr_macos.sh. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2025-11-17T22:21:39Z

Result of foundationdb-pr-clang on Linux RHEL 9

Commit ID: 0f2b559
Duration 0:34:08
Result: ❌ FAILED
Error: Error while executing command: ninja -v -C build_output -j ${NPROC} all packages strip_targets. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2025-11-17T22:24:22Z

Result of foundationdb-pr on Linux RHEL 9

Commit ID: 0f2b559
Duration 0:36:47
Result: ❌ FAILED
Error: Error while executing command: ninja -v -C build_output -j ${NPROC} all packages strip_targets. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2025-11-17T22:26:06Z

Result of foundationdb-pr-clang-arm on Linux CentOS 7

Commit ID: 0f2b559
Duration 0:38:34
Result: ❌ FAILED
Error: Error while executing command: ninja -v -C build_output -j ${NPROC} all packages strip_targets. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2025-11-17T22:26:58Z

Result of foundationdb-pr-cluster-tests on Linux RHEL 9

Commit ID: 0f2b559
Duration 0:39:24
Result: ❌ FAILED
Error: Error while executing command: ninja -v -C build_output -j ${NPROC} all packages strip_targets. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)
Cluster Test Logs zip file of the test logs (available for 30 days)

foundationdb-ci · 2025-11-18T01:15:07Z

Result of foundationdb-pr-clang-arm on Linux CentOS 7

Commit ID: a04ae5e
Duration 0:45:28
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2025-11-18T01:17:29Z

Result of foundationdb-pr on Linux RHEL 9

Commit ID: a04ae5e
Duration 0:47:47
Result: ❌ FAILED
Error: Error while executing command: ctest -j ${NPROC} --no-compress-output -T test --output-on-failure. Reason: exit status 8
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2025-11-18T01:22:25Z

Result of foundationdb-pr-macos on macOS Ventura 13.x

Commit ID: a04ae5e
Duration 0:52:46
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2025-11-18T01:27:36Z

Result of foundationdb-pr-clang-arm on Linux CentOS 7

Commit ID: a04ae5e
Duration 0:46:37
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2025-11-18T01:29:22Z

Result of foundationdb-pr on Linux RHEL 9

Commit ID: a04ae5e
Duration 0:48:26
Result: ❌ FAILED
Error: Error while executing command: if python3 -m joshua.joshua list --stopped | grep ${ENSEMBLE_ID} | grep -q 'pass=10[0-9][0-9][0-9]'; then echo PASS; else echo FAIL && exit 1; fi. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2025-11-18T01:32:45Z

Result of foundationdb-pr-clang on Linux RHEL 9

Commit ID: a04ae5e
Duration 1:03:06
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2025-11-18T01:36:53Z

Result of foundationdb-pr-clang on Linux RHEL 9

Commit ID: a04ae5e
Duration 0:55:58
Result: ❌ FAILED
Error: Error while executing command: if python3 -m joshua.joshua list --stopped | grep ${ENSEMBLE_ID} | grep -q 'pass=10[0-9][0-9][0-9]'; then echo PASS; else echo FAIL && exit 1; fi. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2025-11-18T01:44:21Z

Result of foundationdb-pr-cluster-tests on Linux RHEL 9

Commit ID: a04ae5e
Duration 1:14:41
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)
Cluster Test Logs zip file of the test logs (available for 30 days)

akankshamahajan15 · 2025-11-18T01:49:21Z

Jobs are failing but they are not showing any error:

<Trace>Ensemble stopped
</Trace>
[Container] 2025/11/18 01:30:31.008491 Running command python3 -m joshua.joshua list --stopped | grep ${ENSEMBLE_ID}
  20251118-011249-pr12554-clang-a04ae5ea-1325-f953071e6b920cfe compressed=True data_size=38534095 duration=538589 ended=10000 fail=2 fail_fast=10 max_runs=10000 pass=9998 priority=100 remaining=0 runtime=0:17:41 sanity=False started=10000 stopped=20251118-013030 submitted=20251118-011249 timeout=5400 username=pr12554-clang-a04ae5ea-13250

foundationdb-ci · 2025-11-18T01:52:40Z

Result of foundationdb-pr-cluster-tests on Linux RHEL 9

Commit ID: a04ae5e
Duration 1:11:42
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)
Cluster Test Logs zip file of the test logs (available for 30 days)

foundationdb-ci · 2025-11-18T02:13:42Z

Result of foundationdb-pr-clang-ide on Linux RHEL 9

Commit ID: a04ae5e
Duration 0:23:58
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2025-11-18T02:26:53Z

Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x

Commit ID: a04ae5e
Duration 0:37:07
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2025-11-18T02:35:02Z

Result of foundationdb-pr-clang-arm on Linux CentOS 7

Commit ID: a04ae5e
Duration 0:45:18
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2025-11-18T02:40:04Z

Result of foundationdb-pr-clang on Linux RHEL 9

Commit ID: a04ae5e
Duration 0:50:19
Result: ❌ FAILED
Error: Error while executing command: if python3 -m joshua.joshua list --stopped | grep ${ENSEMBLE_ID} | grep -q 'pass=10[0-9][0-9][0-9]'; then echo PASS; else echo FAIL && exit 1; fi. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2025-11-18T02:42:57Z

Result of foundationdb-pr-macos on macOS Ventura 13.x

Commit ID: a04ae5e
Duration 0:53:09
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

akankshamahajan15 · 2025-11-18T02:43:33Z

TestFile="tests/fast/RangeLockCycle.toml" failing. Unrelated to this change

foundationdb-ci · 2025-11-18T02:53:24Z

Result of foundationdb-pr on Linux RHEL 9

Commit ID: a04ae5e
Duration 1:03:36
Result: ❌ FAILED
Error: Error while executing command: if python3 -m joshua.joshua list --stopped | grep ${ENSEMBLE_ID} | grep -q 'pass=10[0-9][0-9][0-9]'; then echo PASS; else echo FAIL && exit 1; fi. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2025-11-18T02:58:39Z

Result of foundationdb-pr-cluster-tests on Linux RHEL 9

Commit ID: a04ae5e
Duration 1:08:53
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)
Cluster Test Logs zip file of the test logs (available for 30 days)

foundationdb-ci · 2025-11-18T03:45:08Z

Result of foundationdb-pr-clang-ide on Linux RHEL 9

Commit ID: a04ae5e
Duration 0:24:16
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2025-11-18T03:58:22Z

Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x

Commit ID: a04ae5e
Duration 0:37:29
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2025-11-18T04:06:01Z

Result of foundationdb-pr-clang-arm on Linux CentOS 7

Commit ID: a04ae5e
Duration 0:45:06
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2025-11-18T04:13:58Z

Result of foundationdb-pr-macos on macOS Ventura 13.x

Commit ID: a04ae5e
Duration 0:53:03
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2025-11-18T04:27:10Z

Result of foundationdb-pr on Linux RHEL 9

Commit ID: a04ae5e
Duration 1:06:18
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2025-11-18T04:27:25Z

Result of foundationdb-pr-clang on Linux RHEL 9

Commit ID: a04ae5e
Duration 1:06:31
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2025-11-18T04:31:56Z

Result of foundationdb-pr-cluster-tests on Linux RHEL 9

Commit ID: a04ae5e
Duration 1:11:01
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)
Cluster Test Logs zip file of the test logs (available for 30 days)

neethuhaneesha · 2025-11-19T22:09:05Z

fdbbackup/backup.actor.cpp

+		    .detail("EncryptionKeyFile",
+		            options.encryptionKeyFile.present() ? options.encryptionKeyFile.get() : "None");
+		bc = openBackupContainer(
+		    exeBackup.toString().c_str(), options.destURL.get(), options.proxy, options.encryptionKeyFile);


In the case of, they give the same URL but a new encryption key what will happen?

That's a great point. I didn't check that scenario.
From the code - it looks like it will start encrypting with the new encryption key as container will be opened unless container gives an error if reopened.

Let me try this scenario first.

akankshamahajan15 requested a review from neethuhaneesha November 14, 2025 19:24

neethuhaneesha reviewed Nov 17, 2025

View reviewed changes

akankshamahajan15 force-pushed the backup_fix branch from 3217796 to 0f2b559 Compare November 17, 2025 21:47

akankshamahajan15 requested a review from neethuhaneesha November 17, 2025 21:48

akankshamahajan15 closed this Nov 18, 2025

akankshamahajan15 reopened this Nov 18, 2025

akankshamahajan15 closed this Nov 18, 2025

akankshamahajan15 reopened this Nov 18, 2025

neethuhaneesha reviewed Nov 19, 2025

View reviewed changes

Provide encryption support with fdbbackup modify command #12554

Are you sure you want to change the base?

Provide encryption support with fdbbackup modify command #12554

Conversation

akankshamahajan15 commented Nov 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Testing

Uh oh!

foundationdb-ci commented Nov 14, 2025

Result of foundationdb-pr-clang-ide on Linux RHEL 9

Uh oh!

foundationdb-ci commented Nov 14, 2025

Result of foundationdb-pr-clang-arm on Linux CentOS 7

Uh oh!

foundationdb-ci commented Nov 14, 2025

Result of foundationdb-pr-cluster-tests on Linux RHEL 9

Uh oh!

foundationdb-ci commented Nov 14, 2025

Result of foundationdb-pr on Linux RHEL 9

Uh oh!

foundationdb-ci commented Nov 14, 2025

Result of foundationdb-pr-clang on Linux RHEL 9

Uh oh!

akankshamahajan15 commented Nov 14, 2025

Uh oh!

foundationdb-ci commented Nov 14, 2025

Result of foundationdb-pr-clang on Linux RHEL 9

Uh oh!

foundationdb-ci commented Nov 14, 2025

Result of foundationdb-pr-clang-ide on Linux RHEL 9

Uh oh!

foundationdb-ci commented Nov 14, 2025

Result of foundationdb-pr-cluster-tests on Linux RHEL 9

Uh oh!

foundationdb-ci commented Nov 14, 2025

Result of foundationdb-pr on Linux RHEL 9

Uh oh!

foundationdb-ci commented Nov 14, 2025

Result of foundationdb-pr-clang-arm on Linux CentOS 7

Uh oh!

foundationdb-ci commented Nov 14, 2025

Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x

Uh oh!

foundationdb-ci commented Nov 14, 2025

Result of foundationdb-pr-macos on macOS Ventura 13.x

Uh oh!

foundationdb-ci commented Nov 14, 2025

Result of foundationdb-pr-clang-ide on Linux RHEL 9

Uh oh!

foundationdb-ci commented Nov 14, 2025

Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x

Uh oh!

foundationdb-ci commented Nov 14, 2025

Result of foundationdb-pr-clang-arm on Linux CentOS 7

Uh oh!

foundationdb-ci commented Nov 14, 2025

Result of foundationdb-pr on Linux RHEL 9

Uh oh!

foundationdb-ci commented Nov 14, 2025

Result of foundationdb-pr-macos on macOS Ventura 13.x

Uh oh!

foundationdb-ci commented Nov 14, 2025

Result of foundationdb-pr-clang on Linux RHEL 9

Uh oh!

foundationdb-ci commented Nov 14, 2025

Result of foundationdb-pr-cluster-tests on Linux RHEL 9

Uh oh!

neethuhaneesha Nov 17, 2025

Choose a reason for hiding this comment

Uh oh!

akankshamahajan15 Nov 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

akankshamahajan15 Nov 17, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

foundationdb-ci commented Nov 17, 2025

akankshamahajan15 commented Nov 14, 2025 •

edited

Loading

akankshamahajan15 Nov 17, 2025 •

edited

Loading