feat: move export into dedicated menu action, increase spacing between buttons #104
Conversation
|
If you feel that the clear button should have a different style, I can undo the change/unify the style. Maybe action buttons should have a different style from toggle buttons in general. |
|
We are starting to have more buttons in the top right, maybe we should think about better organization for them in the future instead of just icons? |
|
Agreed. Happy to do a design session sometime. |
| > | ||
| Clear | ||
| </button> | ||
| <Button label="Clear" title="Clear filters" onClick={resetFilter} /> |
There was a problem hiding this comment.
Should we keep the existing clear button style (more rounded and with a larger gap between other buttons)?
| <Button label="Clear" title="Clear filters" onClick={resetFilter} /> | ||
|
|
||
| {#if onExportSelection} | ||
| <PopupButton label="Export" title="Export Selection"> |
There was a problem hiding this comment.
Let's find an icon for the export button?
| </div> | ||
| <div class="flex flex-none flex-row gap-0.5"> | ||
|
|
||
| <div class="flex flex-none flex-row gap-2"> |
There was a problem hiding this comment.
How about gap-1? gap-2 is a bit too large IMO.
There was a problem hiding this comment.
I think it creates a nice grouping of the three buttons for changing the layout. With gap 1
with gap 2
Co-authored-by: Donghao Ren <[email protected]>
Co-authored-by: Donghao Ren <[email protected]>
|
I created a box for the selection and used icons. 
|
| checked: boolean; | ||
| label?: string | null; | ||
| icon?: any | null; | ||
| class?: string | null; |
There was a problem hiding this comment.
Ah thanks. I missed that one.
Reason for change: many people don't seem to know about export but it's very powerful for integrating the tool into workflows.
Before:
After:
v2