-
Notifications
You must be signed in to change notification settings - Fork 542
Add Macro for Passing Down OptionGroups #717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Mcrich23
wants to merge
13
commits into
apple:main
Choose a base branch
from
Mcrich23:add-command-option-group-function-macro
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add Macro for Passing Down OptionGroups #717
Mcrich23
wants to merge
13
commits into
apple:main
from
Mcrich23:add-command-option-group-function-macro
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmk142789
approved these changes
Oct 6, 2025
1 task
Contributor
Author
|
Closes #633 |
Contributor
Author
|
@jglogan Any thoughts towards the status of this PR? I know you all have a lot going on, but this has been open for more than a month and is currently the hold on me writing documentation about plugins. It doesn't have to be merged, but I would love insight into this idea. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Motivation and Context
With the new plugin command exposure, challenges arose around passing down option groups to maintain user preferences without massive developer work (#633). This PR addresses the issue using a macro that will automatically adapt as flags and options are added or changed in the future. The only requirement for a developer to adopt the new changes will be to recompile their code.
Testing