Skip to content

Commit 67d7a3d

Browse files
committed
fix(laravel): use lowercase asc/desc for Eloquent orderBy
Laravel's Builder::orderBy() type-hints 'asc'|'desc'|SortDirection, not 'ASC'|'DESC'.
1 parent 4455295 commit 67d7a3d

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

src/Laravel/Eloquent/Filter/OrderFilter.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,8 +45,8 @@ public function apply(Builder $builder, mixed $values, Parameter $parameter, arr
4545
return $builder;
4646
}
4747

48-
$direction = strtoupper($values);
49-
if (!\in_array($direction, ['ASC', 'DESC'], true)) {
48+
$direction = strtolower($values);
49+
if (!\in_array($direction, ['asc', 'desc'], true)) {
5050
return $builder;
5151
}
5252

0 commit comments

Comments
 (0)