Skip to content

Commit a7ab372

Browse files
Bump prettier from 2.8.8 to 3.6.2 (actions#873)
* Bump prettier from 2.8.8 to 3.6.2 Bumps [prettier](https://github.com/prettier/prettier) from 2.8.8 to 3.6.2. - [Release notes](https://github.com/prettier/prettier/releases) - [Changelog](https://github.com/prettier/prettier/blob/main/CHANGELOG.md) - [Commits](prettier/prettier@2.8.8...3.6.2) --- updated-dependencies: - dependency-name: prettier dependency-version: 3.6.2 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> * doc update and check failure fix * npm run format-check * doc format update * doc update * doc update --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Aparna Jyothi <[email protected]>
1 parent d0351b4 commit a7ab372

File tree

8 files changed

+30
-29
lines changed

8 files changed

+30
-29
lines changed

README.md

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,13 @@ The `setup-java` action provides the following functionality for GitHub Actions
1818

1919
This action allows you to work with Java and Scala projects.
2020

21+
## Breaking changes in V5
22+
23+
- Upgraded action from node20 to node24
24+
> Make sure your runner is on version v2.327.1 or later to ensure compatibility with this release [Release Notes](https://github.com/actions/runner/releases/tag/v2.327.1)
25+
26+
For more details, see the full release notes on the [releases page](https://github.com/actions/setup-java/releases/tag/v5.0.0)
27+
2128
## V2 vs V1
2229

2330
- V2 supports custom distributions and provides support for Azul Zulu OpenJDK, Eclipse Temurin and AdoptOpenJDK out of the box. V1 supports only Azul Zulu OpenJDK.

__tests__/distributors/corretto-installer.test.ts

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -150,9 +150,8 @@ describe('getAvailableVersions', () => {
150150
});
151151
mockPlatform(distribution, platform);
152152

153-
const availableVersion = await distribution['findPackageForDownload'](
154-
version
155-
);
153+
const availableVersion =
154+
await distribution['findPackageForDownload'](version);
156155
expect(availableVersion).not.toBeNull();
157156
expect(availableVersion.url).toBe(expectedLink);
158157
});
@@ -222,9 +221,8 @@ describe('getAvailableVersions', () => {
222221

223222
const expectedLink = `https://corretto.aws/downloads/resources/17.0.2.8.1/amazon-corretto-17.0.2.8.1-macosx-${distroArch}.tar.gz`;
224223

225-
const availableVersion = await distribution['findPackageForDownload'](
226-
'17'
227-
);
224+
const availableVersion =
225+
await distribution['findPackageForDownload']('17');
228226
expect(availableVersion).not.toBeNull();
229227
expect(availableVersion.url).toBe(expectedLink);
230228
}

__tests__/distributors/dragonwell-installer.test.ts

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -206,9 +206,8 @@ describe('getAvailableVersions', () => {
206206
});
207207
mockPlatform(distribution, platform);
208208

209-
const availableVersion = await distribution['findPackageForDownload'](
210-
jdkVersion
211-
);
209+
const availableVersion =
210+
await distribution['findPackageForDownload'](jdkVersion);
212211
expect(availableVersion).not.toBeNull();
213212
expect(availableVersion.url).toBe(expectedLink);
214213
}

__tests__/distributors/jetbrains-installer.test.ts

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -76,9 +76,8 @@ describe('findPackageForDownload', () => {
7676
checkLatest: false
7777
});
7878
distribution['getAvailableVersions'] = async () => manifestData as any;
79-
const resolvedVersion = await distribution['findPackageForDownload'](
80-
input
81-
);
79+
const resolvedVersion =
80+
await distribution['findPackageForDownload'](input);
8281
const url = resolvedVersion.url;
8382
const options = {method: 'HEAD'};
8483

__tests__/distributors/sapmachine-installer.test.ts

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -61,9 +61,8 @@ describe('getAvailableVersions', () => {
6161

6262
mockPlatform(distribution, 'linux');
6363

64-
const availableVersion = await distribution['findPackageForDownload'](
65-
version
66-
);
64+
const availableVersion =
65+
await distribution['findPackageForDownload'](version);
6766
expect(availableVersion).not.toBeNull();
6867
expect(availableVersion.url).toBe(
6968
'https://github.com/SAP/SapMachine/releases/download/sapmachine-17.0.10/sapmachine-jdk-17.0.10_linux-x64_bin.tar.gz'
@@ -230,9 +229,8 @@ describe('getAvailableVersions', () => {
230229
});
231230
mockPlatform(distribution, platform);
232231

233-
const availableVersion = await distribution['findPackageForDownload'](
234-
normalizedVersion
235-
);
232+
const availableVersion =
233+
await distribution['findPackageForDownload'](normalizedVersion);
236234
expect(availableVersion).not.toBeNull();
237235
expect(availableVersion.url).toBe(expectedLink);
238236
}

package-lock.json

Lines changed: 7 additions & 6 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
"private": true,
55
"description": "setup java action",
66
"main": "dist/setup/index.js",
7-
"engines": {
7+
"engines": {
88
"node": ">=24.0.0"
99
},
1010
"scripts": {
@@ -52,7 +52,7 @@
5252
"eslint-plugin-node": "^11.1.0",
5353
"jest": "^29.7.0",
5454
"jest-circus": "^29.7.0",
55-
"prettier": "^2.8.4",
55+
"prettier": "^3.6.2",
5656
"ts-jest": "^29.3.0",
5757
"typescript": "^5.3.3"
5858
},

src/toolchains.ts

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -59,9 +59,8 @@ export async function createToolchainsSettings({
5959
// when an alternate m2 location is specified use only that location (no .m2 directory)
6060
// otherwise use the home/.m2/ path
6161
await io.mkdirP(settingsDirectory);
62-
const originalToolchains = await readExistingToolchainsFile(
63-
settingsDirectory
64-
);
62+
const originalToolchains =
63+
await readExistingToolchainsFile(settingsDirectory);
6564
const updatedToolchains = generateToolchainDefinition(
6665
originalToolchains,
6766
jdkInfo.version,

0 commit comments

Comments
 (0)