Skip to content

Commit 0d1cde3

Browse files
matlo607Matthieu Longo
authored andcommitted
fix paths to test binaries
1 parent fa598ea commit 0d1cde3

File tree

5 files changed

+35
-16
lines changed

5 files changed

+35
-16
lines changed

examples/c/proactor/CMakeLists.txt

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -28,9 +28,9 @@ add_definitions(${COMPILE_LANGUAGE_FLAGS} ${COMPILE_WARNING_FLAGS} ${WERROR} ${C
2828

2929
# Add a test with the correct environment to find test executables and valgrind.
3030
if(WIN32)
31-
set(test_path "$<TARGET_FILE_DIR:broker>;$<TARGET_FILE_DIR:qpid-proton>")
31+
set(test_path "${CMAKE_RUNTIME_OUTPUT_DIRECTORY};$<TARGET_FILE_DIR:broker>;$<TARGET_FILE_DIR:qpid-proton>")
3232
else(WIN32)
33-
set(test_path "${CMAKE_CURRENT_BINARY_DIR}:$ENV{PATH}")
33+
set(test_path "${CMAKE_RUNTIME_OUTPUT_DIRECTORY}:$ENV{PATH}")
3434
endif(WIN32)
3535

3636
foreach(name broker send receive direct)
@@ -41,4 +41,5 @@ endforeach()
4141

4242
set(run_env ${PYTHON_EXECUTABLE} ${CMAKE_SOURCE_DIR}/proton-c/env.py ${EXAMPLE_ENV} "PATH=${test_path}" ${VALGRIND_ENV})
4343

44-
add_test(c-example-proactor ${run_env} -- ${PYTHON_EXECUTABLE} ${CMAKE_CURRENT_SOURCE_DIR}/example_test.py -v)
44+
add_test(NAME c-example-proactor COMMAND ${run_env} -- ${PYTHON_EXECUTABLE} ${CMAKE_CURRENT_SOURCE_DIR}/example_test.py -v)
45+
#WORKING_DIRECTORY ${CMAKE_RUNTIME_OUTPUT_DIRECTORY})

examples/cpp/CMakeLists.txt

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,12 +26,13 @@ add_definitions(${CXX_WARNING_FLAGS})
2626
# Add a test with the correct environment to find test executables and valgrind.
2727
macro(add_cpp_test name)
2828
if(WIN32)
29-
set(test_path "$<TARGET_FILE_DIR:broker>;$<TARGET_FILE_DIR:qpid-proton>;$<TARGET_FILE_DIR:qpid-proton-cpp>")
29+
set(test_path "${CMAKE_RUNTIME_OUTPUT_DIRECTORY};$<TARGET_FILE_DIR:broker>;$<TARGET_FILE_DIR:qpid-proton>;$<TARGET_FILE_DIR:qpid-proton-cpp>")
3030
else(WIN32)
31-
set(test_path "$<TARGET_FILE_DIR:broker>:$ENV{PATH}")
31+
set(test_path "${CMAKE_RUNTIME_OUTPUT_DIRECTORY}:$ENV{PATH}")
3232
endif(WIN32)
3333
set(run_env ${PYTHON_EXECUTABLE} ${CMAKE_SOURCE_DIR}/proton-c/env.py ${EXAMPLE_ENV})
3434
add_test(NAME ${name} COMMAND ${run_env} "PATH=${test_path}" ${VALGRIND_ENV} -- ${ARGN})
35+
#WORKING_DIRECTORY ${CMAKE_RUNTIME_OUTPUT_DIRECTORY})
3536
endmacro()
3637

3738
# Single-threaded examples that work on C++03

proton-c/CMakeLists.txt

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -640,10 +640,14 @@ if (qpid-proton-proactor)
640640
)
641641
endif()
642642

643+
if (NOT BIN_INSTALL_DIR)
644+
set(BIN_INSTALL_DIR "bin")
645+
endif(NOT BIN_INSTALL_DIR)
646+
643647
# Install executables and libraries
644648
install(TARGETS qpid-proton qpid-proton-core ${LIB_TARGETS}
645649
EXPORT proton
646-
RUNTIME DESTINATION bin
650+
RUNTIME DESTINATION ${BIN_INSTALL_DIR}
647651
ARCHIVE DESTINATION ${LIB_INSTALL_DIR}
648652
LIBRARY DESTINATION ${LIB_INSTALL_DIR})
649653

proton-c/bindings/cpp/CMakeLists.txt

Lines changed: 13 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -103,10 +103,13 @@ set_target_properties (
103103
)
104104

105105
## Install
106+
if (NOT BIN_INSTALL_DIR)
107+
set(BIN_INSTALL_DIR "bin")
108+
endif(NOT BIN_INSTALL_DIR)
106109

107110
install(TARGETS qpid-proton-cpp
108111
EXPORT proton-cpp
109-
RUNTIME DESTINATION bin
112+
RUNTIME DESTINATION ${BIN_INSTALL_DIR}
110113
ARCHIVE DESTINATION ${LIB_INSTALL_DIR}
111114
LIBRARY DESTINATION ${LIB_INSTALL_DIR})
112115

@@ -132,11 +135,11 @@ install (FILES
132135
DESTINATION ${LIB_INSTALL_DIR}/pkgconfig)
133136

134137
if (DEFINED CMAKE_IMPORT_LIBRARY_PREFIX)
135-
set(PROTONCPPLIB ${CMAKE_IMPORT_LIBRARY_PREFIX}qpid-proton-cpp${CMAKE_IMPORT_LIBRARY_SUFFIX})
136-
set(PROTONCPPLIBDEBUG ${CMAKE_IMPORT_LIBRARY_PREFIX}qpid-proton-cpp${CMAKE_DEBUG_POSTFIX}${CMAKE_IMPORT_LIBRARY_SUFFIX})
138+
set(PROTONCPPLIB ${CMAKE_IMPORT_LIBRARY_PREFIX}qpid-proton-cpp${CMAKE_IMPORT_LIBRARY_SUFFIX})
139+
set(PROTONCPPLIBDEBUG ${CMAKE_IMPORT_LIBRARY_PREFIX}qpid-proton-cpp${CMAKE_DEBUG_POSTFIX}${CMAKE_IMPORT_LIBRARY_SUFFIX})
137140
else ()
138-
set(PROTONCPPLIB ${CMAKE_SHARED_LIBRARY_PREFIX}qpid-proton-cpp${CMAKE_SHARED_LIBRARY_SUFFIX})
139-
set(PROTONCPPLIBDEBUG ${CMAKE_SHARED_LIBRARY_PREFIX}qpid-proton-cpp${CMAKE_DEBUG_POSTFIX}${CMAKE_SHARED_LIBRARY_SUFFIX})
141+
set(PROTONCPPLIB ${CMAKE_SHARED_LIBRARY_PREFIX}qpid-proton-cpp${CMAKE_SHARED_LIBRARY_SUFFIX})
142+
set(PROTONCPPLIBDEBUG ${CMAKE_SHARED_LIBRARY_PREFIX}qpid-proton-cpp${CMAKE_DEBUG_POSTFIX}${CMAKE_SHARED_LIBRARY_SUFFIX})
140143
endif ()
141144

142145
include(WriteBasicConfigVersionFile)
@@ -158,6 +161,10 @@ if (ENABLE_VALGRIND AND VALGRIND_EXE)
158161
set(memcheck-cmd ${VALGRIND_EXE} --error-exitcode=42 --quiet --leak-check=full --trace-children=yes)
159162
endif ()
160163

164+
if (NOT CMAKE_RUNTIME_OUTPUT_DIRECTORY)
165+
set(CMAKE_RUNTIME_OUTPUT_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR})
166+
endif (NOT CMAKE_RUNTIME_OUTPUT_DIRECTORY)
167+
161168
macro(add_cpp_test test)
162169
add_executable (${test} src/${test}.cpp)
163170
target_link_libraries (${test} qpid-proton qpid-proton-cpp)
@@ -167,7 +174,7 @@ macro(add_cpp_test test)
167174
"PATH=$<TARGET_FILE_DIR:qpid-proton>"
168175
$<TARGET_FILE:${test}> ${ARGN})
169176
else ()
170-
add_test (NAME cpp-${test} COMMAND ${memcheck-cmd} ${CMAKE_CURRENT_BINARY_DIR}/${test} ${ARGN})
177+
add_test (NAME cpp-${test} COMMAND ${memcheck-cmd} ${CMAKE_RUNTIME_OUTPUT_DIRECTORY}/${test} ${ARGN})
171178
endif ()
172179
endmacro(add_cpp_test)
173180

proton-c/src/tests/CMakeLists.txt

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,10 @@ if (ENABLE_VALGRIND AND VALGRIND_EXE)
2828
--suppressions=${CMAKE_CURRENT_SOURCE_DIR}/valgrind.supp)
2929
endif ()
3030

31+
if (NOT CMAKE_RUNTIME_OUTPUT_DIRECTORY)
32+
set(CMAKE_RUNTIME_OUTPUT_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR})
33+
endif (NOT CMAKE_RUNTIME_OUTPUT_DIRECTORY)
34+
3135
macro (pn_add_c_test test)
3236
add_executable (${test} ${ARGN})
3337
target_link_libraries (${test} qpid-proton ${PLATFORM_LIBS})
@@ -40,7 +44,7 @@ macro (pn_add_c_test test)
4044
"PATH=$<TARGET_FILE_DIR:qpid-proton>"
4145
$<TARGET_FILE:${test}>)
4246
else ()
43-
add_test (${test} ${memcheck-cmd} ${CMAKE_CURRENT_BINARY_DIR}/${test})
47+
add_test (${test} ${memcheck-cmd} ${CMAKE_RUNTIME_OUTPUT_DIRECTORY}/${test})
4448
endif ()
4549
endmacro(pn_add_c_test)
4650

@@ -65,11 +69,13 @@ if(HAS_PROACTOR)
6569
if(WIN32)
6670
# set(path "$<TARGET_FILE_DIR:proactor-broker>;$<TARGET_FILE_DIR:qpid-proton>")
6771
else(WIN32)
68-
set(path "${CMAKE_CURRENT_BINARY_DIR}:${CMAKE_BINARY_DIR}/examples/c/proactor:$ENV{PATH}")
72+
set(test_path "${CMAKE_CURRENT_BINARY_DIR}:$<TARGET_FILE_DIR:proactor-broker>:${CMAKE_RUNTIME_OUTPUT_DIRECTORY}:$ENV{PATH}")
6973
endif(WIN32)
7074
# Add the tools directory for the 'proctest' module
7175
set_search_path(pypath "${CMAKE_SOURCE_DIR}/tools/py" "$ENV{PYTHON_PATH}")
7276

73-
add_test(NAME c-fdlimit-tests COMMAND ${PYTHON_EXECUTABLE} ${CMAKE_CURRENT_SOURCE_DIR}/fdlimit.py)
74-
set_tests_properties(c-fdlimit-tests PROPERTIES ENVIRONMENT "PATH=${path};PYTHONPATH=${pypath}")
77+
set(run_env ${PYTHON_EXECUTABLE} ${CMAKE_SOURCE_DIR}/proton-c/env.py "PATH=${test_path}" "PYTHONPATH=${pypath}")
78+
add_test(NAME c-fdlimit-tests COMMAND ${run_env} -- ${PYTHON_EXECUTABLE} ${CMAKE_CURRENT_SOURCE_DIR}/fdlimit.py)
79+
#WORKING_DIRECTORY ${CMAKE_RUNTIME_OUTPUT_DIRECTORY})
80+
set_tests_properties(c-fdlimit-tests PROPERTIES ENVIRONMENT "PATH=${test_path};PYTHONPATH=${pypath}")
7581
endif(HAS_PROACTOR)

0 commit comments

Comments
 (0)