review: PATH_STYLE_ACCESS_DEFAULT, ternary

Author: dimas-b

polaris-core/src/main/java/org/apache/polaris/core/storage/aws/AwsStorageConfigurationInfo.java

@@ -26,14 +26,15 @@
 import jakarta.annotation.Nullable;
 import java.net.URI;
 import java.util.List;
-import java.util.Optional;
 import java.util.regex.Matcher;
 import java.util.regex.Pattern;
 import org.apache.polaris.core.storage.PolarisStorageConfigurationInfo;
 
 /** Aws Polaris Storage Configuration information */
 public class AwsStorageConfigurationInfo extends PolarisStorageConfigurationInfo {
 
+  private static final boolean PATH_STYLE_ACCESS_DEFAULT = false;
+
   // Technically, it should be ^arn:(aws|aws-cn|aws-us-gov):iam::(\d{12}):role/.+$,
   @JsonIgnore
   public static final String ROLE_ARN_PATTERN = "^arn:(aws|aws-us-gov):iam::(\\d{12}):role/.+$";
@@ -84,15 +85,23 @@ public AwsStorageConfigurationInfo(
     this.region = region;
     this.endpoint = endpoint;
     this.stsEndpoint = stsEndpoint;
-    this.pathStyleAccess = Optional.ofNullable(pathStyleAccess).orElse(false);
+    this.pathStyleAccess = pathStyleAccess == null ? PATH_STYLE_ACCESS_DEFAULT : pathStyleAccess;
   }
 
   public AwsStorageConfigurationInfo(
       @Nonnull StorageType storageType,
       @Nonnull List<String> allowedLocations,
       @Nonnull String roleARN,
       @Nullable String region) {
-    this(storageType, allowedLocations, roleARN, null, region, null, null, false);
+    this(
+        storageType,
+        allowedLocations,
+        roleARN,
+        null,
+        region,
+        null,
+        null,
+        PATH_STYLE_ACCESS_DEFAULT);
   }
 
   public AwsStorageConfigurationInfo(
@@ -101,7 +110,15 @@ public AwsStorageConfigurationInfo(
       @Nonnull String roleARN,
       @Nullable String externalId,
       @Nullable String region) {
-    this(storageType, allowedLocations, roleARN, externalId, region, null, null, false);
+    this(
+        storageType,
+        allowedLocations,
+        roleARN,
+        externalId,
+        region,
+        null,
+        null,
+        PATH_STYLE_ACCESS_DEFAULT);
   }
 
   @Override