WIP: [C++] Bump to CMake 3.25+ to use FetchContent

Author: wgtmac

CMakeLists.txt

@@ -15,7 +15,7 @@
 # specific language governing permissions and limitations
 # under the License.
 
-cmake_minimum_required (VERSION 3.12.0)
+cmake_minimum_required (VERSION 3.25.0)
 if (POLICY CMP0048)
     cmake_policy(SET CMP0048 NEW)
 endif ()

c++/src/CMakeLists.txt

@@ -119,8 +119,8 @@ CHECK_CXX_SOURCE_RUNS("
   HAS_POST_2038
 )
 
-set(CMAKE_REQUIRED_INCLUDES ${ZLIB_INCLUDE_DIR})
-set(CMAKE_REQUIRED_LIBRARIES orc_zlib)
+set(CMAKE_REQUIRED_INCLUDES ${ZLIB_INCLUDE_DIRS})
+set(CMAKE_REQUIRED_LIBRARIES ${ZLIB_LIBRARIES})
 CHECK_CXX_SOURCE_COMPILES("
     #define Z_PREFIX
     #include<zlib.h>
@@ -205,14 +205,14 @@ add_library (orc STATIC ${SOURCE_FILES})
 target_link_libraries (orc
   INTERFACE
     ${ORC_INSTALL_INTERFACE_TARGETS}
-  PRIVATE
+  PUBLIC
     $<BUILD_INTERFACE:orc::protobuf>
     $<BUILD_INTERFACE:orc::zlib>
-    $<BUILD_INTERFACE:orc::snappy>
+    $<BUILD_INTERFACE:orc::Snappy>
     $<BUILD_INTERFACE:orc::lz4>
     $<BUILD_INTERFACE:orc::zstd>
     $<BUILD_INTERFACE:${LIBHDFSPP_LIBRARIES}>
-    $<BUILD_INTERFACE:${SPARSEHASH_LIBRARIES}>
+    $<BUILD_INTERFACE:$<TARGET_NAME_IF_EXISTS:orc::sparsehash>>
   )
 
 target_include_directories (orc

c++/test/CMakeLists.txt

@@ -62,10 +62,6 @@ add_executable (orc-test
 
 target_link_libraries (orc-test
   orc
-  orc::lz4
-  orc::protobuf
-  orc::snappy
-  orc::zlib
   orc::gtest
   orc::gmock
 )
@@ -76,7 +72,6 @@ add_executable (create-test-files
 
 target_link_libraries (create-test-files
   orc
-  orc::protobuf
 )
 
 if (TEST_VALGRIND_MEMCHECK)