Skip to content

Commit 892a12d

Browse files
committed
apply block()
1 parent 76f0294 commit 892a12d

File tree

3 files changed

+274
-296
lines changed

3 files changed

+274
-296
lines changed

c++/orcConfig.cmake.in

Lines changed: 0 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,6 @@
3333

3434
@PACKAGE_INIT@
3535

36-
set(ORC_VENDOR_DEPENDENCIES "@ORC_VENDOR_DEPENDENCIES@")
3736
set(ORC_SYSTEM_DEPENDENCIES "@ORC_SYSTEM_DEPENDENCIES@")
3837

3938
if(DEFINED CMAKE_MODULE_PATH)
@@ -59,30 +58,6 @@ include("${CMAKE_CURRENT_LIST_DIR}/orcTargets.cmake")
5958

6059
get_target_property(orc_static_configurations orc::orc IMPORTED_CONFIGURATIONS)
6160

62-
foreach(dependency ${ORC_VENDOR_DEPENDENCIES})
63-
string(REPLACE "|" ";" dependency_pair ${dependency})
64-
list(LENGTH dependency_pair dependency_pair_length)
65-
if(NOT dependency_pair_length EQUAL 2)
66-
message(FATAL_ERROR "Invalid vendor dependency: ${dependency}")
67-
endif()
68-
list(GET dependency_pair 0 target_name)
69-
list(GET dependency_pair 1 static_lib_name)
70-
71-
add_library("${target_name}" STATIC IMPORTED)
72-
73-
foreach(CONFIGURATION ${orc_static_configurations})
74-
string(TOUPPER "${CONFIGURATION}" CONFIGURATION)
75-
get_target_property(orc_static_location orc::orc LOCATION_${CONFIGURATION})
76-
get_filename_component(orc_lib_dir "${orc_static_location}" DIRECTORY)
77-
set_property(TARGET "${target_name}"
78-
APPEND
79-
PROPERTY IMPORTED_CONFIGURATIONS ${CONFIGURATION})
80-
set_target_properties("${target_name}"
81-
PROPERTIES IMPORTED_LOCATION_${CONFIGURATION}
82-
"${orc_lib_dir}/${static_lib_name}")
83-
endforeach()
84-
endforeach()
85-
8661
check_required_components(orc)
8762

8863
foreach(BUILD_TYPE_SUFFIX

cmake_modules/FindGTestAlt.cmake

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
# GTEST_LIBRARY: path to libgtest
2323
# GMOCK_STATIC_LIB: is set to gmock.a static library
2424
# GTEST_STATIC_LIB: is set to gtest.a static library
25-
# GTESTAlt_FOUND is set if GTEST is found
25+
# GTestAlt_FOUND is set if GTEST is found
2626

2727
if (NOT "${GTEST_HOME}" STREQUAL "")
2828
message (STATUS "GTEST_HOME set: ${GTEST_HOME}")
@@ -52,14 +52,14 @@ find_library (GTEST_STATIC_LIB NAMES ${CMAKE_STATIC_LIBRARY_PREFIX}gtest${CMAKE_
5252
PATH_SUFFIXES "lib")
5353

5454
if (GTEST_INCLUDE_DIR AND GMOCK_LIBRARY)
55-
set (GTESTAlt_FOUND TRUE)
55+
set (GTestAlt_FOUND TRUE)
5656
set (GTEST_HEADER_NAME gmock/gmock.h)
5757
set (GTEST_HEADER ${GTEST_INCLUDE_DIR}/${GTEST_HEADER_NAME})
5858
else ()
59-
set (GTESTAlt_FOUND FALSE)
59+
set (GTestAlt_FOUND FALSE)
6060
endif ()
6161

62-
if (GTESTAlt_FOUND)
62+
if (GTestAlt_FOUND)
6363
message (STATUS "Found the GTest header: ${GTEST_HEADER}")
6464
message (STATUS "Found the GTest library: ${GTEST_LIBRARY}")
6565
message (STATUS "Found the GMock library: ${GMOCK_LIBRARY}")

0 commit comments

Comments
 (0)