Skip to content

Conversation

@nastra
Copy link
Contributor

@nastra nastra commented Nov 27, 2025

Purpose

This adds support for altering Iceberg table properties

Brief change log

Tests

added a unit test that sets/removes table properties

API and Format

Documentation

@MehulBatra MehulBatra requested a review from Copilot November 27, 2025 18:20
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support for altering Iceberg table properties in Fluss. The implementation enables setting and removing table properties with proper conversion between Fluss and Iceberg property key formats.

  • Implements the alterTable method in IcebergLakeCatalog to handle SetOption and ResetOption table changes
  • Adds property key conversion logic to translate between Fluss prefixes (iceberg. and table.) and Iceberg prefixes
  • Comprehensive test coverage for setting, updating, and removing table properties

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
fluss-lake/fluss-lake-iceberg/src/main/java/org/apache/fluss/lake/iceberg/IcebergLakeCatalog.java Implements alterTable method with property update logic and adds convertFlussPropertyKeyToIceberg helper method
fluss-lake/fluss-lake-iceberg/src/test/java/org/apache/fluss/lake/iceberg/IcebergLakeCatalogTest.java Adds comprehensive test for setting, updating, and removing table properties

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@nastra nastra force-pushed the iceberg-support-altering-table-properties branch from b90fd8a to 438c3b4 Compare November 28, 2025 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant