Skip to content

Commit 41cb566

Browse files
committed
Merge branch 'main' into feat/df54-followups-wave2
# Conflicts: # docs/source/user-guide/upgrade-guides.rst
2 parents 95db5ff + 744dd23 commit 41cb566

44 files changed

Lines changed: 2765 additions & 634 deletions

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

.ai/skills/check-upstream/SKILL.md

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,11 +66,17 @@ The user may specify an area via `$ARGUMENTS`. If no area is specified or "all"
6666
- Python API: `python/datafusion/functions.py` — each function wraps a call to `datafusion._internal.functions`
6767
- Rust bindings: `crates/core/src/functions.rs``#[pyfunction]` definitions registered via `init_module()`
6868

69+
**Evaluated and not requiring separate Python exposure:**
70+
- `get_field_path` — already covered by `get_field(expr, *names)`, which takes a
71+
variadic field path and dispatches to the same underlying
72+
`functions::core::get_field` UDF as the upstream `get_field_path` helper.
73+
6974
**How to check:**
7075
1. Fetch the upstream scalar function documentation page
7176
2. Compare against functions listed in `python/datafusion/functions.py` (check the `__all__` list and function definitions)
7277
3. A function is covered if it exists in the Python API — it does NOT need a dedicated Rust `#[pyfunction]`. Many functions are aliases that reuse another function's Rust binding.
73-
4. Only report functions that are missing from the Python `__all__` list / function definitions
78+
4. Check against the "evaluated and not requiring exposure" list before flagging as a gap
79+
5. Only report functions that are missing from the Python `__all__` list / function definitions
7480

7581
### 2. Aggregate Functions
7682

.github/workflows/test.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,9 @@ env:
2929
jobs:
3030
test-matrix:
3131
runs-on: ubuntu-latest
32+
# Backstop: a hung multiprocessing worker (e.g. during a pickle regression)
33+
# should not block CI longer than this.
34+
timeout-minutes: 30
3235
strategy:
3336
fail-fast: false
3437
matrix:

.pre-commit-config.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717

1818
repos:
1919
- repo: https://github.com/rhysd/actionlint
20-
rev: v1.7.6
20+
rev: v1.7.12
2121
hooks:
2222
- id: actionlint-docker
2323
- repo: https://github.com/astral-sh/ruff-pre-commit

0 commit comments

Comments
 (0)