Skip to content

Commit 0a68f41

Browse files
authored
chore: require an approving review before merging (#2394)
Add a protected_branches block to .asf.yaml requiring one approving review on main and the active release branches, matching apache/datafusion and apache/datafusion-comet. Until now the only protection on main was the default ASF Infra ruleset, which restricts deletion and force-push but does not require review.
1 parent fbb8e9a commit 0a68f41

1 file changed

Lines changed: 16 additions & 0 deletions

File tree

‎.asf.yaml‎

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,22 @@ github:
3939
rebase: false
4040
features:
4141
issues: true
42+
# Require at least one approving review before a pull request can be merged,
43+
# matching apache/datafusion and apache/datafusion-comet.
44+
#
45+
# .asf.yaml does not support wildcards here, so each release branch has to be
46+
# listed by name. Add the new branch as part of the release process.
47+
# https://github.com/apache/infrastructure-asfyaml?tab=readme-ov-file#branch-protection
48+
protected_branches:
49+
main:
50+
required_pull_request_reviews:
51+
required_approving_review_count: 1
52+
branch-53:
53+
required_pull_request_reviews:
54+
required_approving_review_count: 1
55+
branch-54:
56+
required_pull_request_reviews:
57+
required_approving_review_count: 1
4258
# publishes the content of the `asf-site` branch to
4359
# https://datafusion.apache.org/ballista/
4460
rulesets:

0 commit comments

Comments
 (0)