Skip to content

Commit f513c2a

Browse files
committed
backup: drop unused backupStatus search condition from listBackups
The backupStatus condition was carried over from main, where #13254 added a status filter to listBackups. 4.22 has neither ListBackupsCmd.getBackupStatus() nor a setParameters call for it, so the condition is never populated and SearchCriteria.getWhereClause() skips it. Dead code on this branch; the statusNeq clause that hides tombstoned chain members is the one in use.
1 parent 45821f1 commit f513c2a

1 file changed

Lines changed: 0 additions & 1 deletion

File tree

server/src/main/java/org/apache/cloudstack/backup/BackupManagerImpl.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -977,7 +977,6 @@ public Pair<List<Backup>, Integer> listBackups(final ListBackupsCmd cmd) {
977977
// Tombstoned chain backups (Status.Hidden) are never shown to users; they exist only so the
978978
// incremental chain GC can sweep them once their last descendant is deleted.
979979
sb.and("statusNeq", sb.entity().getStatus(), SearchCriteria.Op.NEQ);
980-
sb.and("backupStatus", sb.entity().getStatus(), SearchCriteria.Op.EQ);
981980

982981
if (keyword != null) {
983982
sb.and().op("keywordName", sb.entity().getName(), SearchCriteria.Op.LIKE);

0 commit comments

Comments
 (0)