Skip to content

Commit e7e9f6e

Browse files
authored
Apply suggestions from code review
1 parent a3a24ea commit e7e9f6e

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

utils/src/test/java/org/apache/cloudstack/utils/redfish/RedfishClientTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -87,15 +87,15 @@ public void validateAddressAndPrepareForUrlTestIpv6() {
8787
public void buildRequestUrlTestHttpsGetSystemId() {
8888
RedfishClient redfishclient = new RedfishClient(USERNAME, PASSWORD, true, false, REDFISHT_REQUEST_RETRIES);
8989
String result = redfishclient.buildRequestUrl(oobAddress, RedfishClient.RedfishCmdType.GetSystemId, systemId);
90-
String expected = String.format("https://%s/redfish/v1/Systems/", oobAddress);
90+
String expected = String.format("https://%s/redfish/v1/Systems/%s", oobAddress, systemId);
9191
Assert.assertEquals(expected, result);
9292
}
9393

9494
@Test
9595
public void buildRequestUrlTestGetSystemId() {
9696
RedfishClient redfishclient = new RedfishClient(USERNAME, PASSWORD, false, false, REDFISHT_REQUEST_RETRIES);
9797
String result = redfishclient.buildRequestUrl(oobAddress, RedfishClient.RedfishCmdType.GetSystemId, systemId);
98-
String expected = String.format("http://%s/redfish/v1/Systems/", oobAddress);
98+
String expected = String.format("http://%s/redfish/v1/Systems/%s", oobAddress, systemId);
9999
Assert.assertEquals(expected, result);
100100
}
101101

0 commit comments

Comments
 (0)