Use enums for remaining API allowed values

Author: dheeraj12347

api/src/main/java/com/cloud/template/TemplateApiType.java

@@ -0,0 +1,26 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package com.cloud.template;
+
+public enum TemplateApiType {
+    USER,
+    VNF,
+    SYSTEM,
+    ROUTING,
+    BUILTIN
+}

api/src/main/java/org/apache/cloudstack/api/command/admin/vpc/CreateVPCOfferingCmd.java

@@ -50,6 +50,7 @@
 import com.cloud.exception.ResourceAllocationException;
 import com.cloud.network.vpc.VpcOffering;
 import com.cloud.user.Account;
+import com.cloud.utils.net.NetUtils;
 
 import static com.cloud.network.Network.Service.Dhcp;
 import static com.cloud.network.Network.Service.Dns;
@@ -97,10 +98,7 @@ public class CreateVPCOfferingCmd extends BaseAsyncCreateCmd {
         type = CommandType.STRING,
         description = "The internet protocol of the offering. Options are IPv4 and dualstack. Default is IPv4. dualstack will create an offering that supports both IPv4 and IPv6",
         since = "4.17.0",
-        allowedValues = {
-                "IPv4",
-                "DualStack"
-        })
+        allowedValueType = NetUtils.InternetProtocol.class)
     private String internetProtocol;
 
     @Parameter(name = ApiConstants.SERVICE_OFFERING_ID,

api/src/main/java/org/apache/cloudstack/api/command/user/network/ListNetworksCmd.java

@@ -111,7 +111,7 @@ public class ListNetworksCmd extends BaseListRetrieveOnlyResourceCountCmd implem
 
     @Parameter(name = ApiConstants.NETWORK_FILTER,
             type = CommandType.STRING,
-            allowedValues = {"account", "domain", "accountdomain", "shared", "all"},
+            allowedValueType = Network.NetworkFilter.class,
             since = "4.17.0",
             description = "Possible values are \"account\", \"domain\", \"accountdomain\",\"shared\", and \"all\". Default value is \"all\"."
                     + "* account : account networks that have been registered for or created by the calling User. "

api/src/main/java/org/apache/cloudstack/api/command/user/snapshot/ListSnapshotsCmd.java

@@ -30,6 +30,7 @@
 import org.apache.cloudstack.api.response.ZoneResponse;
 
 import com.cloud.storage.Snapshot;
+import com.cloud.utils.DateUtil;
 
 @APICommand(name = "listSnapshots", description = "Lists all available Snapshots for the Account.", responseObject = SnapshotResponse.class, entityType = {
         Snapshot.class }, responseView = ResponseObject.ResponseView.Restricted, requestHasSensitiveInfo = false, responseHasSensitiveInfo = false)

api/src/main/java/org/apache/cloudstack/api/command/user/template/GetUploadParamsForTemplateCmd.java

@@ -37,6 +37,7 @@
 import org.apache.commons.lang3.StringUtils;
 
 import com.cloud.exception.ResourceAllocationException;
+import com.cloud.template.TemplateApiType;
 
 @APICommand(name = "getUploadParamsForTemplate", description = "Upload an existing Template into the CloudStack cloud. ",
         responseObject = GetUploadParamsResponse.class, since = "4.6.0",
@@ -108,7 +109,7 @@ public class GetUploadParamsForTemplateCmd extends AbstractGetUploadParamsCmd {
 
     @Parameter(name = ApiConstants.TEMPLATE_TYPE,
             type = CommandType.STRING,
-            allowedValues = {"USER", "VNF", "SYSTEM", "ROUTING", "BUILTIN"},
+            allowedValueType = TemplateApiType.class,
             description = "the type of the template. Valid options are: USER/VNF (for all users) and SYSTEM/ROUTING/BUILTIN (for admins only).",
             since = "4.22.0")
     private String templateType;

api/src/main/java/org/apache/cloudstack/api/command/user/template/RegisterTemplateCmd.java

@@ -45,6 +45,7 @@
 import com.cloud.exception.ResourceAllocationException;
 import com.cloud.hypervisor.Hypervisor;
 import com.cloud.hypervisor.HypervisorGuru;
+import com.cloud.template.TemplateApiType;
 import com.cloud.template.VirtualMachineTemplate;
 
 @APICommand(name = "registerTemplate", description = "Registers an existing Template into the CloudStack cloud. ", responseObject = TemplateResponse.class, responseView = ResponseView.Restricted,
@@ -182,7 +183,7 @@ public class RegisterTemplateCmd extends BaseCmd implements UserCmd {
 
     @Parameter(name = ApiConstants.TEMPLATE_TYPE,
             type = CommandType.STRING,
-            allowedValues = {"USER", "VNF", "SYSTEM", "ROUTING", "BUILTIN"},
+            allowedValueType = TemplateApiType.class,
             description = "the type of the template. Valid options are: USER/VNF (for all users) and SYSTEM/ROUTING/BUILTIN (for admins only).",
             since = "4.19.0")
     private String templateType;

api/src/main/java/org/apache/cloudstack/api/command/user/template/UpdateTemplateCmd.java

@@ -27,8 +27,9 @@
 import org.apache.cloudstack.api.command.user.UserCmd;
 import org.apache.cloudstack.api.response.TemplateResponse;
 
-import com.cloud.template.VirtualMachineTemplate;
+import com.cloud.template.TemplateApiType;
 import com.cloud.user.Account;
+import com.cloud.template.VirtualMachineTemplate;
 
 @APICommand(name = "updateTemplate", description = "Updates attributes of a Template.", responseObject = TemplateResponse.class, responseView = ResponseView.Restricted,
         requestHasSensitiveInfo = false, responseHasSensitiveInfo = false)
@@ -41,7 +42,7 @@ public class UpdateTemplateCmd extends BaseUpdateTemplateOrIsoCmd implements Use
 
     @Parameter(name = ApiConstants.TEMPLATE_TYPE,
             type = CommandType.STRING,
-            allowedValues = {"USER", "VNF", "SYSTEM", "ROUTING", "BUILTIN"},
+            allowedValueType = TemplateApiType.class,
             description = "The type of the Template. Valid options are: USER/VNF (for all users) and SYSTEM/ROUTING/BUILTIN (for admins only).")
     private String templateType;