Use enums as source for allowedValues

Author: dheeraj12347

api/src/main/java/org/apache/cloudstack/api/Parameter.java

@@ -53,5 +53,8 @@
     ApiArgValidator[] validations() default {};
 
     String[] allowedValues() default {};
+
+    Class<? extends Enum> allowedValueType() default Enum.class;
+
     boolean acceptedOnAdminPort() default true;
 }

api/src/main/java/org/apache/cloudstack/api/command/admin/network/NetworkOfferingBaseCmd.java

@@ -156,7 +156,8 @@ public abstract class NetworkOfferingBaseCmd extends BaseCmd {
     @Parameter(name = ApiConstants.NETWORK_MODE,
             type = CommandType.STRING,
             description = "Indicates the mode with which the network will operate. Valid option: NATTED or ROUTED",
-            since = "4.20.0")
+            since = "4.20.0",
+            allowedValueType = NetworkOffering.NetworkMode.class)
     private String networkMode;
 
     @Parameter(name = ApiConstants.FOR_TUNGSTEN,

api/src/main/java/org/apache/cloudstack/api/command/admin/offering/CreateDiskOfferingCmd.java

@@ -40,6 +40,7 @@
 
 import com.cloud.offering.DiskOffering;
 import com.cloud.offering.ServiceOffering;
+import com.cloud.storage.Storage;
 import com.cloud.storage.Storage.ProvisioningType;
 import com.cloud.user.Account;
 
@@ -86,14 +87,10 @@ public class CreateDiskOfferingCmd extends BaseCmd {
     private String storageType = ServiceOffering.StorageType.shared.toString();
 
     @Parameter(
-        name = ApiConstants.PROVISIONINGTYPE,
-        type = CommandType.STRING,
-        description = "Provisioning type used to create volumes. Valid values are thin, sparse, fat.",
-        allowedValues = {
-                "thin",
-                "sparse",
-                "fat"
-        })
+            name = ApiConstants.PROVISIONINGTYPE,
+            type = CommandType.STRING,
+            description = "Provisioning type used to create volumes. Valid values are thin, sparse, fat.",
+            allowedValueType = Storage.ProvisioningType.class)
     private String provisioningType = ProvisioningType.THIN.toString();
 
     @Parameter(name = ApiConstants.DISPLAY_OFFERING,

api/src/main/java/org/apache/cloudstack/api/command/admin/offering/CreateServiceOfferingCmd.java

@@ -68,15 +68,12 @@ public class CreateServiceOfferingCmd extends BaseCmd {
     private String displayText;
 
     @Parameter(
-        name = ApiConstants.PROVISIONINGTYPE,
-        type = CommandType.STRING,
-        description = "Provisioning type used to create volumes. Valid values are thin, sparse, fat.",
-        allowedValues = {
-                "thin",
-                "sparse",
-                "fat"
-        })
+            name = ApiConstants.PROVISIONINGTYPE,
+            type = CommandType.STRING,
+            description = "Provisioning type used to create volumes. Valid values are thin, sparse, fat.",
+            allowedValueType = Storage.ProvisioningType.class)
     private String provisioningType = Storage.ProvisioningType.THIN.toString();
+
     @Parameter(name = ApiConstants.MEMORY, type = CommandType.INTEGER, required = false, description = "The total memory of the service offering in MB")
     private Integer memory;
 

api/src/main/java/org/apache/cloudstack/api/command/admin/vpc/CreateVPCOfferingCmd.java

@@ -154,10 +154,7 @@ public class CreateVPCOfferingCmd extends BaseAsyncCreateCmd {
         type = CommandType.STRING,
         description = "Indicates the mode with which the network will operate. Valid option: NATTED or ROUTED",
         since = "4.20.0",
-        allowedValues = {
-                "NATTED",
-                "ROUTED"
-        })
+        allowedValueType = NetworkOffering.NetworkMode.class)
     private String networkMode;
 
     @Parameter(name = ApiConstants.SPECIFY_AS_NUMBER, type = CommandType.BOOLEAN, since = "4.20.0",
@@ -167,7 +164,8 @@ public class CreateVPCOfferingCmd extends BaseAsyncCreateCmd {
     @Parameter(name = ApiConstants.ROUTING_MODE,
             type = CommandType.STRING,
             since = "4.20.0",
-            description = "the routing mode for the VPC offering. Supported types are: Static or Dynamic.")
+            description = "the routing mode for the VPC offering. Supported types are: Static or Dynamic.",
+            allowedValueType = NetworkOffering.RoutingMode.class)
     private String routingMode;
 
     @Parameter(name = ApiConstants.CONSERVE_MODE, type = CommandType.BOOLEAN,

api/src/main/java/org/apache/cloudstack/api/command/user/autoscale/CreateConditionCmd.java

@@ -52,13 +52,7 @@ public class CreateConditionCmd extends BaseAsyncCreateCmd {
         type = CommandType.STRING,
         required = true,
         description = "Relational Operator to be used with threshold. Valid values are EQ, GT, LT, GE, LE.",
-        allowedValues = {
-                "EQ",
-                "GT",
-                "LT",
-                "GE",
-                "LE"
-        })
+        allowedValueType = Condition.Operator.class)
     private String relationalOperator;
 
     @Parameter(name = ApiConstants.THRESHOLD, type = CommandType.LONG, required = true, description = "Value for which the Counter will be evaluated with the Operator selected.")

api/src/main/java/org/apache/cloudstack/api/command/user/autoscale/UpdateConditionCmd.java

@@ -54,13 +54,7 @@ public class UpdateConditionCmd extends BaseAsyncCmd {
         type = CommandType.STRING,
         required = true,
         description = "Relational Operator to be used with threshold. Valid values are EQ, GT, LT, GE, LE.",
-        allowedValues = {
-                "EQ",
-                "GT",
-                "LT",
-                "GE",
-                "LE"
-        })
+        allowedValueType = Condition.Operator.class)
     private String relationalOperator;
 
     @Parameter(name = ApiConstants.THRESHOLD, type = CommandType.LONG, required = true, description = "Value for which the Counter will be evaluated with the Operator selected.")

api/src/main/java/org/apache/cloudstack/api/command/user/backup/CreateBackupScheduleCmd.java

@@ -59,12 +59,7 @@ public class CreateBackupScheduleCmd extends BaseCmd {
         type = CommandType.STRING,
         required = true,
         description = "Valid values are HOURLY, DAILY, WEEKLY, and MONTHLY",
-        allowedValues = {
-                "HOURLY",
-                "DAILY",
-                "WEEKLY",
-                "MONTHLY"
-        })
+        allowedValueType = DateUtil.IntervalType.class)
     private String intervalType;
 
     @Parameter(name = ApiConstants.SCHEDULE,

api/src/main/java/org/apache/cloudstack/api/command/user/ipv6/CreateIpv6FirewallRuleCmd.java

@@ -83,10 +83,7 @@ public class CreateIpv6FirewallRuleCmd extends BaseAsyncCreateCmd {
     name = ApiConstants.TRAFFIC_TYPE,
     type = CommandType.STRING,
     description = "The traffic type for the Ipv6 firewall rule, can be ingress or egress, defaulted to ingress if not specified",
-    allowedValues = {
-        "Ingress",
-        "Egress"
-    })
+    allowedValueType = FirewallRule.TrafficType.class)
     private String trafficType;
 
     @Parameter(name = ApiConstants.FOR_DISPLAY, type = CommandType.BOOLEAN, description = "An optional field, whether to the display the rule to the end User or not", authorized = {RoleType.Admin})

api/src/main/java/org/apache/cloudstack/api/command/user/iso/ListIsosCmd.java

@@ -70,15 +70,7 @@ public class ListIsosCmd extends BaseListTaggedResourcesCmd implements UserCmd {
                + "* executable : Templates that are owned by the calling User, or public Templates, that can be used to deploy an Instance. "
                + "* community : Templates that have been marked as public but not featured. "
                + "* all : all Templates (only usable by admins).",
-           allowedValues = {
-               "featured",
-               "self",
-               "selfexecutable",
-               "sharedexecutable",
-               "executable",
-               "community",
-               "all"
-           })
+           allowedValueType = TemplateFilter.class)
     private String isoFilter = TemplateFilter.selfexecutable.toString();
 
     @Parameter(name = ApiConstants.NAME, type = CommandType.STRING, description = "List all ISOs by name")
@@ -100,11 +92,7 @@ public class ListIsosCmd extends BaseListTaggedResourcesCmd implements UserCmd {
         type = CommandType.STRING,
         description = "the CPU arch of the ISO. Valid options are: x86_64, aarch64, s390x",
         since = "4.20",
-        allowedValues = {
-            "x86_64",
-            "aarch64",
-            "s390x"
-        })
+        allowedValueType = CPU.CPUArch.class)
     private String arch;
 
     @Parameter(name = ApiConstants.OS_CATEGORY_ID, type = CommandType.UUID, entityType= GuestOSCategoryResponse.class,