Fix AvaticaSpnegoTest for canonicalHostName("localhost") != "localhost"

Avatica HTTP client always uses CANONICAL_HOSTNAME which confuses test code.

Author: vlsi

build.gradle.kts

@@ -329,6 +329,20 @@ allprojects {
                     exceptionFormat = TestExceptionFormat.FULL
                     showStandardStreams = true
                 }
+                // Pass the property to tests
+                fun passProperty(name: String, default: String? = null) {
+                    val value = System.getProperty(name) ?: default
+                    value?.let { systemProperty(name, it) }
+                }
+                passProperty("java.awt.headless")
+                passProperty("user.language", "TR")
+                passProperty("user.country", "tr")
+                val props = System.getProperties()
+                for (e in props.propertyNames() as `java.util`.Enumeration<String>) {
+                    if (e.startsWith("calcite.") || e.startsWith("avatica.")) {
+                        passProperty(e)
+                    }
+                }
             }
             withType<SpotBugsTask>().configureEach {
                 group = LifecycleBasePlugin.VERIFICATION_GROUP

core/src/main/java/org/apache/calcite/avatica/remote/AvaticaCommonsHttpClientSpnegoImpl.java

@@ -55,7 +55,9 @@ public class AvaticaCommonsHttpClientSpnegoImpl extends AvaticaCommonsHttpClient
   public static final String CACHED_CONNECTIONS_MAX_PER_ROUTE_KEY =
       "avatica.http.spnego.max_per_route";
 
-  private static final boolean USE_CANONICAL_HOSTNAME = true;
+  private static final boolean USE_CANONICAL_HOSTNAME =
+      Boolean.parseBoolean(
+           System.getProperty("avatica.http.spnego.use_canonical_hostname", "true"));
   private static final boolean STRIP_PORT_ON_SERVER_LOOKUP = true;
 
   /**

server/src/test/java/org/apache/calcite/avatica/AvaticaSpnegoTest.java

@@ -70,6 +70,9 @@ private static void setupKdc() throws Exception {
     if (isKdcStarted) {
       return;
     }
+    if (System.getProperty("avatica.http.spnego.use_canonical_hostname") == null) {
+      System.setProperty("avatica.http.spnego.use_canonical_hostname", "false");
+    }
     kdc = new SimpleKdcServer();
     File target = SpnegoTestUtil.TARGET_DIR;
     assertTrue(target.exists());