up

Author: yew1eb

native-engine/auron-serde/src/from_proto.rs

@@ -1292,12 +1292,12 @@ impl From<&protobuf::ColumnStats> for ColumnStatistics {
             max_value: cs
                 .max_value
                 .as_ref()
-                .map(|m| Precision::Exact(m.try_into().expect("max_value")))
+                .map(|m| Precision::Exact(m.try_into().expect("invalid max_value")))
                 .unwrap_or(Precision::Absent),
             min_value: cs
                 .min_value
                 .as_ref()
-                .map(|m| Precision::Exact(m.try_into().expect("min_value")))
+                .map(|m| Precision::Exact(m.try_into().expect("invalid min_value")))
                 .unwrap_or(Precision::Absent),
             sum_value: Precision::Absent,
             distinct_count: Precision::Exact(cs.distinct_count as usize),

native-engine/datafusion-ext-commons/src/arrow/cast.rs

@@ -354,7 +354,10 @@ fn try_cast_string_array_to_integer(array: &dyn Array, cast_type: &DataType) ->
     macro_rules! cast {
         ($target_type:ident) => {{
             type B = paste::paste! {[<$target_type Builder>]};
-            let string_array = as_string_array(array);
+            let string_array = array
+                .as_any()
+                .downcast_ref::<StringArray>()
+                .expect("Expected a StringArray");
             let mut builder = B::new();
 
             for v in string_array.iter() {

native-engine/datafusion-ext-commons/src/io/scalar_serde.rs

@@ -42,7 +42,7 @@ pub fn write_scalar<W: Write>(value: &ScalarValue, nullable: bool, output: &mut
                     write_u8(0, output)?;
                 }
             } else {
-                output.write_all(&$v.expect("ok").to_ne_bytes())?;
+                output.write_all(&$v.expect("non-null value required").to_ne_bytes())?;
             }
         }};
     }

native-engine/datafusion-ext-plans/src/joins/test.rs

@@ -91,8 +91,11 @@ mod tests {
     }
 
     fn build_table_from_batches(batches: Vec<RecordBatch>) -> Arc<dyn ExecutionPlan> {
-        let schema = batches.first().expect("first").schema();
-        Arc::new(TestMemoryExec::try_new(&[batches], schema, None).expect("memory_exec"))
+        let schema = batches.first().expect("missing first batch").schema();
+        Arc::new(
+            TestMemoryExec::try_new(&[batches], schema, None)
+                .expect("failed to create memory exec"),
+        )
     }
 
     fn build_date_table(
@@ -618,12 +621,12 @@ mod tests {
             ("a1", &vec![Some(1), Some(2), None, Some(4), Some(5)]),
             ("b1", &vec![Some(4), Some(5), Some(6), None, Some(8)]),
             ("c1", &vec![Some(7), Some(8), Some(9), Some(10), Some(11)]),
-        );
+        )?;
         let right = build_table_i32_nullable(
             ("a2", &vec![Some(10), Some(20), Some(30)]),
             ("b1", &vec![Some(4), Some(5), Some(7)]),
             ("c2", &vec![Some(70), Some(80), Some(90)]),
-        );
+        )?;
         let on: JoinOn = vec![(
             Arc::new(Column::new_with_schema("b1", &left.schema())?),
             Arc::new(Column::new_with_schema("b1", &right.schema())?),