GH-46797: [C++] Support Meson on Windows

Author: WillAyd

.github/workflows/cpp_extra.yml

@@ -133,6 +133,7 @@ jobs:
           - image: conda-cpp
             run-options: >-
               -e ARROW_USE_MESON=ON
+              -e MESON_SETUP_ARGS="-Dauto_features=enabled -Dfuzzing=disabled -Dgcs=disabled -Ds3=disabled"
             runs-on: ubuntu-latest
             title: AMD64 Ubuntu Meson
           # TODO: We should remove this "continue-on-error: true" once GH-47207 is resolved
@@ -278,3 +279,70 @@ jobs:
           cmake --build cpp/examples/minimal_build.build
           cd cpp/examples/minimal_build
           ../minimal_build.build/arrow-example
+
+  meson-windows:
+    needs: check-labels
+    name: ${{ matrix.title }}
+    runs-on: ${{ matrix.runs-on }}
+    if: needs.check-labels.outputs.ci-extra == 'true'
+    timeout-minutes: 75
+    strategy:
+      fail-fast: false
+      matrix:
+        include:
+            - runs-on: windows-2022
+              title: AMD64 Windows Meson
+    steps:
+      - name: Checkout Arrow
+        uses: actions/checkout@v4
+        with:
+          fetch-depth: 0
+          submodules: recursive
+      - name: Download Timezone Database
+        shell: bash
+        run: ci/scripts/download_tz_database.sh
+      - name: Install ccache
+        shell: bash
+        run: |
+          ci/scripts/install_ccache.sh 4.6.3 /usr
+      - name: Setup ccache
+        shell: bash
+        run: |
+          ci/scripts/ccache_setup.sh
+      - name: ccache info
+        id: ccache-info
+        shell: bash
+        run: |
+          echo "cache-dir=$(ccache --get-config cache_dir)" >> $GITHUB_OUTPUT
+      - name: Cache ccache
+        uses: actions/cache@v4
+        with:
+          path: ${{ steps.ccache-info.outputs.cache-dir }}
+          key: cpp-ccache-windows-meson-${{ env.CACHE_VERSION }}-${{ hashFiles('cpp/**') }}
+          restore-keys: cpp-ccache-windows-meson-${{ env.CACHE_VERSION }}-
+        env:
+          # We can invalidate the current cache by updating this.
+          CACHE_VERSION: "2022-09-13"
+      - name: Setup Python
+        uses: actions/setup-python@a26af69be951a213d495a4c3e4e4022e16d87065 # v5.6.0
+        with:
+          python-version: 3
+      - name: Install Meson
+        run: |
+          python3 -m pip install meson
+      - name: Build
+        shell: bash
+        env:
+          ARROW_USE_MESON: ON
+          ARROW_HOME: C:\arrow-dist
+          MESON_SETUP_ARGS: "--vsenv -Dauto_features=enabled -Dfuzzing=disabled -Dgcs=disabled -Ds3=disabled -Dazure=disabled"
+        run: |
+          ci/scripts/cpp_build.sh $(pwd) $(pwd)/build
+      - name: Test
+        shell: bash
+        env:
+          ARROW_USE_MESON: ON
+        run: |
+          # For ORC
+          export TZDIR=/c/msys64/usr/share/zoneinfo
+          ci/scripts/cpp_test.sh $(pwd) $(pwd)/build

ci/scripts/cpp_build.sh

@@ -142,10 +142,7 @@ if [ "${ARROW_USE_MESON:-OFF}" = "ON" ]; then
   meson setup \
     --prefix=${MESON_PREFIX:-${ARROW_HOME}} \
     --buildtype=${ARROW_BUILD_TYPE:-debug} \
-    -Dauto_features=enabled \
-    -Dfuzzing=disabled \
-    -Dgcs=disabled \
-    -Ds3=disabled \
+    ${MESON_SETUP_ARGS} \
     . \
     ${source_dir}
 

ci/scripts/cpp_test.sh

@@ -95,6 +95,8 @@ if [ "${ARROW_USE_MESON:-OFF}" = "ON" ]; then
     --no-rebuild \
     --print-errorlogs \
     --suite arrow \
+    --max-lines=0 \
+    --timeout-multiplier 10 \
     "$@"
 else
   ctest \

cpp/meson.build

@@ -31,6 +31,7 @@ project_args = [
     '-Wno-stringop-overflow',
     '-Wno-aggressive-loop-optimizations',
     '-Wno-nonnull',
+    '/bigobj',
 ]
 
 c_compiler = meson.get_compiler('c')

cpp/src/arrow/acero/meson.build

@@ -82,9 +82,19 @@ arrow_acero_lib = library(
     sources: arrow_acero_srcs,
     dependencies: [arrow_compute_dep, arrow_dep, threads_dep],
     gnu_symbol_visibility: 'hidden',
+    cpp_shared_args: ['-DARROW_ACERO_EXPORTING'],
+    cpp_static_args: ['-DARROW_ACERO_STATIC'],
 )
 
-arrow_acero_dep = declare_dependency(link_with: [arrow_acero_lib])
+arrow_acero_compile_args = []
+if get_option('default_library') != 'shared'
+    arrow_acero_compile_args += ['-DARROW_ACERO_STATIC']
+endif
+
+arrow_acero_dep = declare_dependency(
+    link_with: [arrow_acero_lib],
+    compile_args: arrow_acero_compile_args,
+)
 
 arrow_acero_testing_sources = ['test_nodes.cc', 'test_util_internal.cc']
 
@@ -137,8 +147,7 @@ foreach key, val : arrow_acero_benchmarks
         dependencies: [
             arrow_acero_dep,
             arrow_compute_test_dep,
-            arrow_benchmark_dep,
-            gmock_dep,
+            benchmark_main_dep,
         ],
     )
     benchmark(key, exc)

cpp/src/arrow/compute/CMakeLists.txt

@@ -47,6 +47,7 @@ if(ARROW_TESTING AND ARROW_COMPUTE)
     target_link_libraries(arrow_compute_testing
                           PUBLIC $<TARGET_OBJECTS:arrow_compute_core_testing>
                           PUBLIC ${ARROW_GTEST_GTEST_MAIN})
+    target_compile_definitions(arrow_compute_testing PRIVATE COMPILED_BY_CMAKE)
   else()
     target_link_libraries(arrow_compute_testing
                           PUBLIC $<TARGET_OBJECTS:arrow_compute_core_testing>

cpp/src/arrow/compute/kernels/meson.build

@@ -152,7 +152,7 @@ endforeach
 exc = executable(
     'arrow-compute-aggregate-test',
     sources: ['aggregate_test.cc'] + kernel_testing_srcs,
-    dependencies: [arrow_compute_test_dep, filesystem_dep],
+    dependencies: [arrow_compute_test_dep, boost_deps],
 )
 test('arrow-compute-aggregate-test', exc)
 

cpp/src/arrow/compute/meson.build

@@ -50,7 +50,7 @@ endif
 # Define arrow_compute_core_testing object library for common test files requiring
 # only core compute. No extra kernels are required.
 if needs_testing
-    arrow_compute_core_test_lib = library(
+    arrow_compute_core_test_lib = static_library(
         'arrow-compute-core-testing',
         sources: files('test_util_internal.cc'),
         dependencies: arrow_test_dep,
@@ -64,7 +64,7 @@ endif
 
 # Define arrow_compute_testing object library for test files requiring extra kernels.
 if needs_testing and needs_compute
-    arrow_compute_testing_lib = library(
+    arrow_compute_testing_lib = static_library(
         'arrow-compute-testing',
         sources: files('test_env.cc'),
         dependencies: [

cpp/src/arrow/compute/test_env.cc

@@ -35,15 +35,15 @@ class ComputeKernelEnvironment : public ::testing::Environment {
 
 }  // namespace
 
-#ifdef _MSC_VER
+#if defined(_MSC_VER) && defined(COMPILED_BY_CMAKE)
 // Initialize the compute module
 ::testing::Environment* compute_kernels_env =
     ::testing::AddGlobalTestEnvironment(new ComputeKernelEnvironment);
 #endif
 
 }  // namespace arrow::compute
 
-#ifndef _MSC_VER
+#if !(defined(_MSC_VER) && defined(COMPILED_BY_CMAKE))
 int main(int argc, char** argv) {
   ::testing::InitGoogleTest(&argc, argv);
   ::testing::AddGlobalTestEnvironment(new arrow::compute::ComputeKernelEnvironment);

cpp/src/arrow/filesystem/meson.build

@@ -47,7 +47,7 @@ test_cpp_arg = '-DARROW_FILESYSTEM_EXAMPLE_LIBPATH="@0@"'.format(
 exc = executable(
     'arrow-filesystem-test',
     sources: ['filesystem_test.cc', 'localfs_test.cc'],
-    dependencies: [arrow_test_dep],
+    dependencies: [arrow_test_dep, arrow_filesystem_example_dep],
     cpp_args: test_cpp_arg,
 )
 test('arrow-filesystem-test', exc)