-
Notifications
You must be signed in to change notification settings - Fork 422
Description
I tried to use VivaGraphJS and I'm happy with the first results, but I'm having troubles using it because - although opensource - I don't have access to all the licenses of the specific version pointed in the VivaGraphJS/package.json (I'm on the latest version, which now is v0.12.0) because some of the ngraph dependencies have no tags, thus I cannot point to the source code of the specific version.
The ones I spotted:
- ngraph.events is missing 0.0.3 version tag (latest version is 1.2.1, vivagraphjs needs 0.0.3, there is no 0.3.0 tag)
- ngraph.merge has no version tags (the version in package.json is 1.0.0, vivagraphjs needs 0.0.1)
- ngraph.centrality version has been updated to 2.0.0 in master, might be worth to create a tag (there is one for 0.3.0)
- ngraph.random is missing 0.0.1 version tag, it only has 0.1.0 and 1.0.0
- ngraph.expose is missing 0.0.0 version tag, it has not tags and latest version is 1.0.0
I also noticed that vivagraphjs v0.12.0 needs ngraph.fromjson v0.1.9 and ngraph.graph v0.0.14, meanwhile ngraph.fromjson v0.1.9 needs ngraph.graph v18.0.0, which cause a conflict (ngraph.graph is needed both at v18.0.0 and v0.0.14). There are also a couple more conflicts, but I forgot to take a note... Sorry...
Wouldn't be simpler to pack all the ngraph.* libraries under one single package (e.g. ngraph)? In this way everything moves together and it would much easier to track.
For my use case I managed to find the various commit (ngraph.events: 0.0.3, ngraph.merge: 0.0.1, ngraph.random: 0.0.1, ngraph.expose: 0.0.0), but I think working only on one library would make your life easier.
This is the list of dependencies that might be put together in one ngraph.<bundlename> (they are all written in javascript, to my understanding): gintersect, ngraph.centrality, ngraph.events, ngraph.expose, ngraph.forcelayout, ngraph.fromjson, ngraph.generators, ngraph.graph, ngraph.merge, ngraph.physics.primitives, ngraph.physics.simulator, ngraph.quadtreebh, ngraph.random, ngraph.tojson, simplesvg. (It also might be worth to upgrade add-event-listener).
It's not a strict requirement, honestly it's amazing that there are so little external dependencies (only one, add-event-listener) and you'd ease the adoption for enterprises! :)