test: backfill getAffectedNamespacesForAppliedto

* adds code coverage in networkpolicy package for
  networkPolicyController's getAffectedNamespacesForAppliedto

Signed-off-by: Peter Tran <[email protected]>

Author: petertran-avgo

pkg/controller/networkpolicy/clusternetworkpolicy_test.go

@@ -15,6 +15,7 @@
 package networkpolicy
 
 import (
+	"errors"
 	"fmt"
 	"net"
 	"testing"
@@ -26,11 +27,13 @@ import (
 	"k8s.io/apimachinery/pkg/labels"
 	"k8s.io/apimachinery/pkg/runtime"
 	"k8s.io/apimachinery/pkg/util/sets"
+	corelisters "k8s.io/client-go/listers/core/v1"
 	"k8s.io/utils/ptr"
 
 	"antrea.io/antrea/multicluster/controllers/multicluster/common"
 	"antrea.io/antrea/pkg/apis/controlplane"
 	crdv1beta1 "antrea.io/antrea/pkg/apis/crd/v1beta1"
+	crdv1b1listers "antrea.io/antrea/pkg/client/listers/crd/v1beta1"
 	antreatypes "antrea.io/antrea/pkg/controller/types"
 	"antrea.io/antrea/pkg/util/k8s"
 )
@@ -2445,3 +2448,150 @@ func TestGetACNPsWithRulesMatchingLabelKeysAcrossNSUpdate(t *testing.T) {
 		})
 	}
 }
+
+type mockCGLister struct {
+}
+
+func (m mockCGLister) List(selector labels.Selector) (ret []*crdv1beta1.ClusterGroup, err error) {
+	return []*crdv1beta1.ClusterGroup{{}}, errors.New("always-errors")
+}
+
+func (m mockCGLister) Get(name string) (*crdv1beta1.ClusterGroup, error) {
+	return &crdv1beta1.ClusterGroup{}, errors.New("always-errors")
+}
+
+type mockCGListerA struct {
+}
+
+var labelA = map[string]string{"a": "a"}
+var labelB = map[string]string{"b": "b"}
+var namespaceA = &v1.Namespace{
+	ObjectMeta: metav1.ObjectMeta{
+		Name:   "namespace-a",
+		Labels: labelA,
+	},
+}
+var namespaceB = &v1.Namespace{
+	ObjectMeta: metav1.ObjectMeta{
+		Name:   "namespace-b",
+		Labels: labelB,
+	},
+}
+
+func (m mockCGListerA) List(selector labels.Selector) (ret []*crdv1beta1.ClusterGroup, err error) {
+	return []*crdv1beta1.ClusterGroup{
+		{
+			Spec: crdv1beta1.GroupSpec{
+				NamespaceSelector: &metav1.LabelSelector{
+					MatchLabels: labelA,
+				},
+			},
+		}}, nil
+}
+
+func (m mockCGListerA) Get(name string) (*crdv1beta1.ClusterGroup, error) {
+	if name == "has-pod-selector" {
+		return &crdv1beta1.ClusterGroup{
+			Spec: crdv1beta1.GroupSpec{
+				PodSelector: &metav1.LabelSelector{
+					MatchLabels: map[string]string{"c": "c"},
+				},
+			},
+		}, nil
+	}
+	return &crdv1beta1.ClusterGroup{
+		Spec: crdv1beta1.GroupSpec{
+			NamespaceSelector: &metav1.LabelSelector{
+				MatchLabels: labelA,
+			},
+		},
+	}, nil
+}
+
+type mockNamespaceListerA struct {
+}
+
+func (m mockNamespaceListerA) List(selector labels.Selector) (ret []*v1.Namespace, err error) {
+	return []*v1.Namespace{namespaceA}, nil
+}
+
+func (m mockNamespaceListerA) Get(name string) (*v1.Namespace, error) {
+	return namespaceA, nil
+}
+
+type mockNamespaceListerB struct {
+}
+
+func (m mockNamespaceListerB) List(selector labels.Selector) (ret []*v1.Namespace, err error) {
+	return []*v1.Namespace{namespaceA, namespaceB}, nil
+}
+
+func (m mockNamespaceListerB) Get(name string) (*v1.Namespace, error) {
+	return namespaceA, nil
+}
+
+func TestGetAffectedNamespacesForAppliedTo(t *testing.T) {
+	tests := []struct {
+		name            string
+		appliedTo       crdv1beta1.AppliedTo
+		cgLister        crdv1b1listers.ClusterGroupLister
+		namespaceLister corelisters.NamespaceLister
+		want            map[string]labels.Set
+	}{
+		{
+			"empty appliedTo",
+			crdv1beta1.AppliedTo{},
+			nil,
+			nil,
+			map[string]labels.Set{},
+		},
+		{
+			"match on appliedTo namespaceSelector",
+			crdv1beta1.AppliedTo{NamespaceSelector: &metav1.LabelSelector{MatchLabels: map[string]string{"a": "a"}}},
+			nil,
+			mockNamespaceListerA{},
+			map[string]labels.Set{"namespace-a": labelA},
+		},
+		{
+			"cluster group lister errors",
+			crdv1beta1.AppliedTo{Group: "non-empty"},
+			mockCGLister{},
+			nil,
+			map[string]labels.Set{},
+		},
+		{
+			"matching namespace for group's namespaceSelector",
+			crdv1beta1.AppliedTo{Group: "non-empty"},
+			mockCGListerA{},
+			mockNamespaceListerA{},
+			map[string]labels.Set{"namespace-a": labelA},
+		},
+		{
+			"match all namespace for empty namespaceSelector",
+			crdv1beta1.AppliedTo{},
+			mockCGListerA{},
+			mockNamespaceListerB{},
+			map[string]labels.Set{"namespace-a": labelA, "namespace-b": labelB},
+		},
+		{
+			"match all namespace when namespaceSeletor is nil but podSelector is not",
+			crdv1beta1.AppliedTo{Group: "has-pod-selector"},
+			mockCGListerA{},
+			mockNamespaceListerB{},
+			map[string]labels.Set{"namespace-a": labelA, "namespace-b": labelB},
+		},
+	}
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			_, npc := newController(nil, nil)
+			if tt.cgLister != nil {
+				npc.cgLister = tt.cgLister
+			}
+			if tt.namespaceLister != nil {
+				npc.namespaceLister = tt.namespaceLister
+			}
+			got := npc.getAffectedNamespacesForAppliedTo(tt.appliedTo)
+			assert.Equal(t, tt.want, got)
+		})
+	}
+}